Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set React's onChange property for input elements if its not provided #1283

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Set React's onChange property for input elements if its not provided #1283

wants to merge 1 commit into from

Conversation

JamesHutchison
Copy link
Contributor

Description

Add onChange to input elements

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@JamesHutchison
Copy link
Contributor Author

It doesn't seem like there should be any side effects to this change since it is aligning the behavior when on_change is and is not provided

@Archmonger Archmonger changed the base branch from main to develop March 8, 2025 02:12
@Archmonger
Copy link
Contributor

Needs regression tests and fixes for failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesHutchison @Archmonger