Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix code semells #134

Merged
merged 3 commits into from
Jan 28, 2025
Merged

refactor: fix code semells #134

merged 3 commits into from
Jan 28, 2025

Conversation

luisgomez29
Copy link
Contributor

  • refactor: fix code smells
  • docs: Update RabbitMQ documentation

@luisgomez29 luisgomez29 marked this pull request as ready for review January 28, 2025 16:35
juancgalvis
juancgalvis approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@juancgalvis juancgalvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

async/async-commons/src/main/java/org/reactivecommons/async/commons/DLQDiscardNotifier.java Outdated Show resolved Hide resolved
@juancgalvis juancgalvis merged commit 4235ab8 into reactive-commons:master Jan 28, 2025
1 check passed
@luisgomez29 luisgomez29 deleted the feature/fix-code-semlls branch January 28, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancgalvis juancgalvis juancgalvis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisgomez29 @juancgalvis @lugomez29