Repository navigation
Type-only fixes for Flow's TypeScript iterator defaults - #2276
Conversation
Summary: A future Flow lib change gives the iterator types TypeScript's defaults: `IteratorObject<T>` becomes `IteratorObject<T, unknown, unknown>` (was `void, void`). metro's `mapIterable` spells out the old defaults (`IteratorObject<S, void, void>`) instead, since `S` is not in scope inside it. This diff adjusts it ahead of time. Differential Revision: D133808530
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D133808530. |
Metro review: Looks goodRisk: low · Commit: This PR only changes a type. It writes out No findings. Verified
Not run: I didn't check the change against the future Flow lib defaults, because that lib isn't available. No tests or benchmarks were run: the change is to a type annotation only, with no runtime effect. The description has no Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call. |
Summary:
A future Flow lib change gives the iterator types TypeScript's defaults:
IteratorObject<T>becomesIteratorObject<T, unknown, unknown>(wasvoid, void).metro's
mapIterablespells out the old defaults (IteratorObject<S, void, void>) instead, sinceSis not in scope inside it. This diff adjusts it ahead of time.Differential Revision: D133808530