Skip to content

Let the review bot label, retract and reply - #2248

Merged
robhogan merged 1 commit into
mainfrom
pr2248
Nov 18, 2026
Merged

robhogan merged 1 commit into
mainfrom
pr2248

Conversation

@robhogan

@robhogan robhogan commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

This lets the review bot do three more things through this workflow:

  • Label PRs it skips, like Dependabot bumps and mechanical Flow upgrades, as Auto review: Skipped instead of commenting. Labels come from a fixed allowlist, and the label is created on first use.
  • Delete its own comments: a whole review, or single findings it withdraws or replaces.
  • Reply in the threads of its own findings.

It only deletes or replies to its own finding comments and its replies in their threads, never to other github-actions[bot] comments.

Changelog: Internal

Test plan:
repository_dispatch workflows only run from main, so I ran the script against a mocked github/core/context: the existing review cases, labels, retract, delete, replace and replies, the payloads it should reject, and findings whose text mentions another finding's id. actionlint is clean.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2026
This lets the review bot do three more things through this workflow:

- Label PRs it skips, like Dependabot bumps and mechanical Flow upgrades, as `Auto review: Skipped` instead of commenting. Labels come from a fixed allowlist, and the label is created on first use.
- Delete its own comments: a whole review, or single findings it withdraws or replaces.
- Reply in the threads of its own findings.

It only deletes or replies to its own finding comments and its replies in their threads, never to other `github-actions[bot]` comments.

Changelog: Internal

Test plan:
`repository_dispatch` workflows only run from `main`, so I ran the script against a mocked `github`/`core`/`context`: the existing review cases, labels, retract, delete, replace and replies, the payloads it should reject, and findings whose text mentions another finding's id. `actionlint` is clean.
@robhogan
robhogan requested review from huntie and vzaidman November 18, 2026 11:37
@robhogan
robhogan marked this pull request as ready for review November 18, 2026 11:37
@robhogan
robhogan merged commit dca0633 into main Nov 18, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants