Repository navigation
Name function type params and label dictionary keys in Flow libdefs - #2247
Conversation
Summary:
Names the parameters of function types, labels the keys of indexers and drops explicit exact object syntax (`{| |}`) in the Flow library definitions under React Native's `flow-typed/` and `packages/react-native/flow/`, and in Metro's `flow-typed/` (Metro's copies of `environment/node.js` and the `babel`, `babel-types`, `debug` and `yargs` npm libdefs get the same changes as React Native's). They keep type-checking once Flow requires these in library definitions as it already does in other files. Types are unchanged.
Changelog: [Internal]
Differential Revision: D132693291
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D132693291. |
Metro review: Looks goodRisk: low · Commit: This PR edits Flow libdefs only. It names function-type parameters, labels indexer keys, and swaps the explicit exact syntax No findings. Verified
Not run: I ran no benchmarks, because the change is type-only and nothing changes at runtime. I didn't run Jest either, since no runtime code changed. Windows doesn't apply here. Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call. |
Summary:
Names the parameters of function types, labels the keys of indexers and drops explicit exact object syntax (
{| |}) in the Flow library definitions under React Native'sflow-typed/andpackages/react-native/flow/, and in Metro'sflow-typed/(Metro's copies ofenvironment/node.jsand thebabel,babel-types,debugandyargsnpm libdefs get the same changes as React Native's). They keep type-checking once Flow requires these in library definitions as it already does in other files. Types are unchanged.Changelog: [Internal]
Differential Revision: D132693291