feat(Modal): add new render options for modal#122
Merged
Conversation
kyletsang
commented
Mar 28, 2025
|
|
||
| export interface ImperativeTransitionProps extends TransitionProps { | ||
| transition: TransitionHandler; | ||
| appear: true; |
Collaborator
Author
There was a problem hiding this comment.
These types conflict with the new code since they are used as an intersection with the regular transition props. Since they aren't used in the code, can we remove?
Member
There was a problem hiding this comment.
I think these are here bc the run transition version doesn't support other values
Collaborator
Author
There was a problem hiding this comment.
I removed it, and seems to be ok from my testing. Is this good to merge @jquense ?
jquense
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new props to control the rendering of the modal. I'm going to use this to fix the behavior of the offcanvas component in react-bootstrap to match upstream's behavior and better support the responsive use case.
mountDialogOnEnter- Whether or not the dialog is initially mounted in the DOMunmountDialogOnExit- Whether or not the dialog element is unmounted when modal is hiddenportal- render using a portal or in place