Skip to content
This repository was archived by the owner on Jan 31, 2026. It is now read-only.

feat(Android): skip sending event when onResults/onPartialResults receive empty array#493

Closed
aladine wants to merge 0 commit intoreact-native-voice:masterfrom
aladine:master
Closed

feat(Android): skip sending event when onResults/onPartialResults receive empty array#493
aladine wants to merge 0 commit intoreact-native-voice:masterfrom
aladine:master

Conversation

@aladine
Copy link
Copy Markdown

@aladine aladine commented Apr 3, 2024

Context:

  • In onResults/onPartialResults sometimes we get empty string and on ReactNative application, we don't need empty string from voice response.
  • To save the roundtrip network call via the bridge, I think it is better to filter out empty string from the array sending via event.
  • Many dependencies are outdated and worth to upgrade.

Proposed changes:

  • Add empty string check before pushing result to array in onResults/onPartialResults
  • Update gradle to 8.3 when open the project as a stand alone project in IDE
  • Replace jcenter to mavenCentral since jcenter is deprecated
  • Update com.android.support:appcompat to androidx equivalent dependency, the default version is 1.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant