Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

Fix strict mode enabled typescript issues #206

Merged
merged 4 commits into from
Apr 19, 2021
Merged

Fix strict mode enabled typescript issues #206

merged 4 commits into from
Apr 19, 2021

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Apr 14, 2021 •
edited
Loading

With this PR the following issues are fixed:

  • Almost all of the critical typescript issues are solved in the app (when the strict mode is visible) except the input ref issue
  • Fixed the critical ThemeReducer tsc issue.
  • Also, I have fixed the invalid Avatar image which was not being fetched from the CDN. [The link was denied access.]
  • Fixed invalid icons on the settings page

Reference: #201

@khushal87 khushal87 mentioned this pull request Apr 15, 2021
Closed
@khushal87 khushal87 marked this pull request as ready for review April 15, 2021 14:55
@khushal87
Copy link
Member Author

@flyingcircle @pranshuchittora Please review.

arpitBhalla
arpitBhalla reviewed Apr 17, 2021
View reviewed changes
Copy link
Member

@arpitBhalla arpitBhalla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

arpitBhalla
arpitBhalla reviewed Apr 17, 2021
View reviewed changes
Copy link
Member

@arpitBhalla arpitBhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushal87 Seems good to me

@khushal87
Copy link
Member Author

Thanks @arpitBhalla for the review.

@flyingcircle flyingcircle merged commit ce40b92 into react-native-elements:next Apr 19, 2021
@khushal87 khushal87 deleted the khushal87-dev branch April 19, 2021 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arpitBhalla arpitBhalla arpitBhalla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushal87 @arpitBhalla @flyingcircle