Add Privacy Manifest #189
Open
Add Privacy Manifest #189
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add privacy manifest about NSUserDefaults usage
add resource bundles to include PrivacyInfo as resource
|
I had the same issue, thank you for the correction. Could you please review @safaiyeh |
ym0724
approved these changes
Apr 11, 2024
|
any idea when will this be merged? |
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Feb 6, 2025
…es` (#6482) ### Description Migrate `@react-native-cookies/cookies` to `@divvi/cookies` The patch changes are implemented in the fork: react-native-cookies/cookies@master...divvixyz:cookies:master Although we are not using it directly, it is a [peer dependency](https://github.com/fiatconnect/fiatconnect-sdk/blob/065ba70bd5dde23fa186d161072eb024e0cde40d/package.json#L56) for `fiatconnect-sdk` (this package is already [updated](fiatconnect/fiatconnect-sdk#330)). ### TODO Migrate back to the original package once react-native-cookies/cookies#189 is merged. ### Test plan * CI * Next release App Store submission (patch is adding the `PrivacyInfo.xcprivacy` file) ### Related issues - Related to RET-1308 ### Backwards compatibility Y ### Network scalability NA
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Feb 6, 2025
…es` (#6482) ### Description Migrate `@react-native-cookies/cookies` to `@divvi/cookies` The patch changes are implemented in the fork: react-native-cookies/cookies@master...divvixyz:cookies:master Although we are not using it directly, it is a [peer dependency](https://github.com/fiatconnect/fiatconnect-sdk/blob/065ba70bd5dde23fa186d161072eb024e0cde40d/package.json#L56) for `fiatconnect-sdk` (this package is already [updated](fiatconnect/fiatconnect-sdk#330)). ### TODO Migrate back to the original package once react-native-cookies/cookies#189 is merged. ### Test plan * CI * Next release App Store submission (patch is adding the `PrivacyInfo.xcprivacy` file) ### Related issues - Related to RET-1308 ### Backwards compatibility Y ### Network scalability NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Privacy Manifest for NSUserDefaults usage.
I'm not sure if adding a Privacy Manifest is the right approach for this library because I don't believe (or I'm not certain) this library collects any user information through NSUserDefaults.
If you have any ideas (or if I'm missing something), please comment below.
p.s.)
If you archive your project and then generate Privacy Report as PDF, you can see RNCookiePrivacyInfo.bundle like below :