-
-
Notifications
You must be signed in to change notification settings - Fork 323
Revert "fix: value is not work when set to null" #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 6bc9cb4.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caution Review failedThe pull request is closed. Walkthrough在 Changes
Sequence Diagram(s)sequenceDiagram
participant UI as 用户/组件
participant Hook as useRangeValue
participant Merged as useMergedState
UI ->> Hook: 调用 useRangeValue(value)
Hook ->> Merged: 直接传入 value(不做 null 检查)
Merged -->> Hook: 返回 innerValue(直接映射传入 value)
Hook -->> UI: 返回 innerValue
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
src/PickerInput/hooks/useRangeValue.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /.eslintrc.js
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
==========================================
- Coverage 98.79% 98.79% -0.01%
==========================================
Files 64 64
Lines 2654 2652 -2
Branches 739 738 -1
==========================================
- Hits 2622 2620 -2
Misses 29 29
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #913
ref #912 (comment)
Summary by CodeRabbit