Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ecAff_isOnCurve #66

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Fix ecAff_isOnCurve #66

merged 2 commits into from
Apr 21, 2024

Conversation

wilsoncusack
Copy link
Contributor

Further to #65

The description of the PR is correct in pointing out that the code accepts x and x+p < 2^256 (and similarly y and y+p < 2^256) as valid while it should only accept x and y. I believe the fix should be adding an additional check that validates if x < p && y < p. Putting it all together, I think the following change should be made:

#65 (comment)

@rdubois-crypto
Copy link
Owner

Fix assures canonic representation (unicity) of a point. OK.

@rdubois-crypto rdubois-crypto merged commit 76f3f13 into rdubois-crypto:master Apr 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilsoncusack @rdubois-crypto