RDKB-63545 : Add PSM defaults for SKY-UK XER10 device#221
Open
aadhithan01 wants to merge 5 commits intodevelopfrom
Open
RDKB-63545 : Add PSM defaults for SKY-UK XER10 device#221aadhithan01 wants to merge 5 commits intodevelopfrom
aadhithan01 wants to merge 5 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds PSM (Persistent Storage Manager) default configuration support for the SKY-UK partner on XER10 devices (model SCER11BEL). The changes enable PSM migration by allowing partner-specific JSON configuration values to be properly applied to PSM storage for this device model.
Changes:
- Added conditional logic in utopia_init.sh to call apply_system_defaults_psm for sky-uk partner on XER10 devices
- Implemented isXER10Device() helper function to detect SCER11BEL devices
- Added support for processing override-only parameters from partner JSON configuration
- Enhanced PSM parameter handling for XER10 devices in the partner defaults application logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/scripts/init/system/utopia_init.sh | Added conditional check to invoke apply_system_defaults_psm for sky-uk partner on XER10 (SCER11BEL) devices |
| source/scripts/init/src/apply_system_defaults_helper.c | Added isXER10Device() function, marked unused function with attribute, implemented override-only parameter processing in two functions, and added XER10-specific PSM logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove redundant XER10-specific logging that duplicates existing log output - Extract duplicated override processing logic into process_override_only_parameters helper function - Reduces code duplication and improves maintainability
This reverts commit 2ac1fb0.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixed memory leak where newParamObj was created but not added to JSON tree when psm_supported or syscfg_supported conditions failed. Now the object is always added to the tree unconditionally at line 2329, with only the database operations remaining conditional. This ensures proper memory cleanup when the root JSON is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the PSM entries for the sky-uk partner ID, enabling the PSM migration, which will take the partner_json values to the PSM values
TEST STEPS : https://ccp.sys.comcast.net/browse/RDKB-63545
UT:
https://ccp.sys.comcast.net/browse/RDKB-63545?focusedId=24617629&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24617629