gh #67 add amlogic & vdevice player config#68
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds player configurations for two new platforms: amlogic_polaris and vdevice. These configurations follow the existing structure in the utPlayerConfig.yml file, defining gstreamer player settings including prerequisites, play/stop commands, and mixer input configurations.
- Added
amlogic_polarisplatform configuration with Westeros and GStreamer prerequisites - Added
vdeviceplatform configuration with minimal prerequisites - Both platforms use gst-play-1.0 as the player command and share similar mixer input configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hari22yuva
force-pushed
the
feature/gh67_Add_amlogic_vdevice_player_configs
branch
from
62f137f to
e77acd9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
configs/utPlayerConfig.yml
Outdated
| play_command: gst-play-1.0 # Player command to play the stream | ||
| stop_command: "\x03" # CNTRL-C | ||
| primary_mixer_input_config: "" | ||
| secondary_mixer_input_config: '--audiosink "amlhalasink direct-mode=0"' |
There was a problem hiding this comment.
The vdevice configuration uses amlhalasink (Amlogic HAL audio sink) in the secondary mixer input config. This seems incorrect for a virtual device platform, as amlhalasink is specific to Amlogic hardware. Consider using a generic audio sink like alsasink or autoaudiosink, or leaving it empty if no secondary mixer is needed for virtual devices.
| secondary_mixer_input_config: '--audiosink "amlhalasink direct-mode=0"' | |
| secondary_mixer_input_config: "" |
| - export XDG_RUNTIME_DIR=/run/user/0 | ||
| - export LD_PRELOAD=libwesteros_gl.so.0.0.0 | ||
| - export WESTEROS_GL_GRAPHICS_MAX_SIZE=1920x1080 | ||
| - export WESTEROS_GL_MODE=3840x2160x60 | ||
| - export WAYLAND_DISPLAY=main0 | ||
| - rm -rf /run/user/0 | ||
| - mkdir -p /run/user/0 |
There was a problem hiding this comment.
The runtime directory /run/user/0 is being removed and recreated (lines 74-75) after it has already been set as XDG_RUNTIME_DIR (line 69). This ordering could cause issues if any process tries to use the directory between line 69 and line 75. Consider moving the export XDG_RUNTIME_DIR=/run/user/0 statement to after the directory is created (after line 75).
| - export XDG_RUNTIME_DIR=/run/user/0 | |
| - export LD_PRELOAD=libwesteros_gl.so.0.0.0 | |
| - export WESTEROS_GL_GRAPHICS_MAX_SIZE=1920x1080 | |
| - export WESTEROS_GL_MODE=3840x2160x60 | |
| - export WAYLAND_DISPLAY=main0 | |
| - rm -rf /run/user/0 | |
| - mkdir -p /run/user/0 | |
| - export LD_PRELOAD=libwesteros_gl.so.0.0.0 | |
| - export WESTEROS_GL_GRAPHICS_MAX_SIZE=1920x1080 | |
| - export WESTEROS_GL_MODE=3840x2160x60 | |
| - export WAYLAND_DISPLAY=main0 | |
| - rm -rf /run/user/0 | |
| - mkdir -p /run/user/0 | |
| - export XDG_RUNTIME_DIR=/run/user/0 |
hari22yuva
force-pushed
the
feature/gh67_Add_amlogic_vdevice_player_configs
branch
from
e77acd9 to
68d8e9a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hari22yuva
force-pushed
the
feature/gh67_Add_amlogic_vdevice_player_configs
branch
from
68d8e9a to
43e7d3a
Compare
hari22yuva
deleted the
feature/gh67_Add_amlogic_vdevice_player_configs
branch
2 participants
No description provided.