Skip to content

RDKB-61542: IPV6 ping failure is high on 8.2 release #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uainap wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDKB-61542: IPV6 ping failure is high on 8.2 release #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 54 additions & 42 deletions scripts/device/tccbr/self_heal_connectivity_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh

Check failure on line 1 in scripts/device/tccbr/self_heal_connectivity_test.sh

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'scripts/device/tccbr/self_heal_connectivity_test.sh' (Match: rdkb/components/opensource/ccsp/TestAndDiagnostic/rdkb/components/opensource/ccsp/TestAndDiagnostic/1, 492 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdkb/components/opensource/ccsp/TestAndDiagnostic/+archive/RDKB-RELEASE-TEST-DUNFELL-1.tar.gz, file: scripts/device/tccbr/self_heal_connectivity_test.sh)
#######################################################################################
# If not stated otherwise in this file or this component's Licenses.txt file the
# following copyright and licenses apply:
Expand Down Expand Up @@ -34,9 +34,9 @@
ping4_server_num=0
ping6_server_num=0
ping4_success=0
ping6_success=0
connectivity_ipv6_success=0
ping4_failed=0
ping6_failed=0
connectivity_ipv6_failed=0

getCorrectiveActionState() {
Corrective_Action=`syscfg get ConnTest_CorrectiveAction`
Expand Down Expand Up @@ -122,6 +122,30 @@
fi
}

checkIPv6ConnectivityRdisc6() {
local wan_interface="$1"

echo_t "RDKB_SELFHEAL : Starting IPv6 connectivity check"

if ! command -v rdisc6 >/dev/null 2>&1; then
echo_t "RDKB_SELFHEAL : rdisc6 not available"
return 0
fi

# Try rdisc6 with increasing attempts
for i in 1 2 3; do
echo_t "RDKB_SELFHEAL : IPv6 connectivity attempt $i of 3"

RDISC_OUTPUT=`rdisc6 -$i -w $((3000 + i * 2000)) $wan_interface 2>/dev/null`
RDISC_RESULT=$?
if [ $RDISC_RESULT -eq 0 ] && [ "$RDISC_OUTPUT" != "" ]; then
return 1 # Success
fi
sleep 5
done
return 0 # Failed
}

runPingTest()
{
PING_PACKET_SIZE=`syscfg get selfheal_ping_DataBlockSize`
Expand Down Expand Up @@ -215,33 +239,21 @@

if [ "$IPv6_Gateway_addr" != "" ]
Copy link
Contributor

@apattu200 apattu200 Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether in current sprint, whether this variable is properly set, I believe we have two addresses set on this variable. can you confirm

then
for IPv6_Gateway_addr in $IPv6_Gateway_addr
do
PING_OUTPUT=`ping6 -I $WAN_INTERFACE -c $PINGCOUNT -w $RESWAITTIME $IPv6_Gateway_addr`
output_ipv6=`echo $?`
CHECK_PACKET_RECEIVED=`echo $PING_OUTPUT | grep "packet loss" | cut -d"%" -f1 | awk '{print $NF}'`

if [ "$CHECK_PACKET_RECEIVED" != "" ]
then
if [ "$CHECK_PACKET_RECEIVED" -ne 100 ]
then
ping6_success=1
ping6_failed=0
PING_LATENCY="PING_LATENCY_GWIPv6:"
PING_LATENCY_VAL=`echo $PING_OUTPUT | awk 'BEGIN {FS="ms"} { for(i=1;i<=NF;i++) print $i}' | grep "time=" | cut -d"=" -f4`
PING_LATENCY_VAL=${PING_LATENCY_VAL%?};
echo $PING_LATENCY$PING_LATENCY_VAL|sed 's/ /,/g'
break
else
ping6_failed=1
fi
else
ping6_failed=1
fi
done
echo_t "RDKB_SELFHEAL : Testing IPv6 connectivity on $WAN_INTERFACE"

# Use the compact IPv6 connectivity check with rdisc6
checkIPv6ConnectivityRdisc6 "$WAN_INTERFACE"
ipv6_connectivity_result=$?

if [ $ipv6_connectivity_result -eq 1 ]; then
connectivity_ipv6_success=1
connectivity_ipv6_failed=0
else
connectivity_ipv6_failed=1
fi
fi

if [ "$ping4_success" -ne 1 ] && [ "$ping6_success" -ne 1 ]
if [ "$ping4_success" -ne 1 ] && [ "$connectivity_ipv6_success" -ne 1 ]
then
echo_t "RDKB_SELFHEAL : Ping to both IPv4 and IPv6 Gateway Address failed."
t2CountNotify "RF_ERROR_IPV4IPV6PingFailed"
Copy link
Contributor

@apattu200 apattu200 Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify this telemetry as well

Expand Down Expand Up @@ -280,12 +292,12 @@
echo_t "RDKB_SELFHEAL : Taking corrective action"
resetNeeded "" PING
fi
elif [ "$ping6_success" -ne 1 ]
elif [ "$connectivity_ipv6_success" -ne 1 ]
then
if [ "$IPv6_Gateway_addr" != "" ]
then
echo_t "RDKB_SELFHEAL : Ping to IPv6 Gateway Address are failed."
t2CountNotify "RF_ERROR_IPV6PingFailed"
echo_t "RDKB_SELFHEAL : IPv6 connectivity test failed."
t2CountNotify "RF_ERROR_IPV6ConnectivityFailed"
else
echo_t "RDKB_SELFHEAL : No IPv6 Gateway Address detected"
t2CountNotify "SYS_INFO_NoIPv6_Address"
Expand All @@ -306,8 +318,8 @@

ping4_success=0
ping4_failed=0
ping6_success=0
ping6_failed=0
connectivity_ipv6_success=0
connectivity_ipv6_failed=0


IPV4_SERVER_COUNT=`syscfg get Ipv4PingServer_Count`
Expand Down Expand Up @@ -362,21 +374,21 @@
then
if [ "$CHECK_PACKET_RECEIVED" -ne 100 ]
then
ping6_success=1
connectivity_ipv6_success=1
Copy link
Contributor

@apattu200 apattu200 Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need our connectivity test variable here. This is based on ipv4 server address and ipv6 address configured. It need not to be CMTS address. Can you please check the expected value here.

PING_LATENCY="PING_LATENCY_IPv6_SERVER:"
PING_LATENCY_VAL=`echo $PING_OUTPUT | awk 'BEGIN {FS="ms"} { for(i=1;i<=NF;i++) print $i}' | grep "time=" | cut -d"=" -f4`
PING_LATENCY_VAL=${PING_LATENCY_VAL%?};
echo $PING_LATENCY$PING_LATENCY_VAL|sed 's/ /,/g'
else
ping6_failed=1
connectivity_ipv6_failed=1
fi
else
ping6_failed=1
connectivity_ipv6_failed=1
fi

if [ "$ping6_failed" -eq 1 ];then
if [ "$connectivity_ipv6_failed" -eq 1 ];then
echo_t "IPERROR_Ping: IP_Host=[$PING_SERVER_IS], Ping_Error = [$output_ping6server]"
ping6_failed=0
connectivity_ipv6_failed=0
fi

fi
Expand All @@ -397,7 +409,7 @@
echo_t "RDKB_SELFHEAL : Taking corrective action"
resetNeeded "" PING
fi
elif [ "$ping6_success" -ne 1 ] && [ "$IPV6_SERVER_COUNT" -ne 0 ]
elif [ "$connectivity_ipv6_success" -ne 1 ] && [ "$IPV6_SERVER_COUNT" -ne 0 ]
then
echo_t "RDKB_SELFHEAL : Ping to IPv6 servers are failed."
if [ `getCorrectiveActionState` = "true" ]
Expand All @@ -410,7 +422,7 @@
echo_t "RDKB_SELFHEAL : Connectivity Test is Successfull"
fi

elif [ "$ping4_success" -ne 1 ] && [ "$ping6_success" -ne 1 ]
elif [ "$ping4_success" -ne 1 ] && [ "$connectivity_ipv6_success" -ne 1 ]
then
echo_t "RDKB_SELFHEAL : Ping to both IPv4 and IPv6 servers are failed."
t2CountNotify "RF_ERROR_IPV4IPV6PingFailed"
Expand All @@ -427,7 +439,7 @@
echo_t "RDKB_SELFHEAL : Taking corrective action"
resetNeeded "" PING
fi
elif [ "$ping6_success" -ne 1 ]
elif [ "$connectivity_ipv6_success" -ne 1 ]
then
echo_t "RDKB_SELFHEAL : Ping to IPv6 servers are failed."
if [ `getCorrectiveActionState` = "true" ]
Expand All @@ -441,8 +453,8 @@

ping4_success=0
ping4_failed=0
ping6_success=0
ping6_failed=0
connectivity_ipv6_success=0
connectivity_ipv6_failed=0
ping4_server_num=0
ping6_server_num=0

Expand Down
Loading
Loading