Skip to content

Comments

Issue 136: Add a flag to disable SVP functionality#148

Merged
riwoh merged 2 commits intordkcentral:mainfrom
harindhu007:feature/Issue_136
Jan 17, 2026
Merged

Issue 136: Add a flag to disable SVP functionality#148
riwoh merged 2 commits intordkcentral:mainfrom
harindhu007:feature/Issue_136

Conversation

@harindhu007
Copy link
Contributor

@harindhu007 harindhu007 commented Jul 17, 2025 •
edited
Loading

Reason for change: Disable/Enable SVP functionality using ENABLE_SVP flag
Risks: None
Priority: P1

@harindhu007
Copy link
Contributor Author

harindhu007 commented Jul 17, 2025 •
edited
Loading

SVP Functionality Disabled

root@0a8a282e0cc2:/home/ubuntu/hsrini103/tasecureapi/reference# nm ./cmake-build/src/client/libsaclient.so | grep svp
0000000000025b08 T sa_svp_supported
0000000000058ba8 T svp_supported
000000000002c184 t ta_invoke_svp_supported
0000000000040528 T ta_sa_svp_supported

SVP Functionality Enabled

root@0a8a282e0cc2:/home/ubuntu/hsrini103/tasecureapi/reference# nm ./cmake-build/src/client/libsaclient.so | grep svp
000000000004a1f0 T client_get_svp_store
0000000000043d24 T memory_is_valid_svp
0000000000025aec T sa_svp_buffer_alloc
00000000000258b0 T sa_svp_buffer_check
0000000000025c1c T sa_svp_buffer_copy
00000000000269bc T sa_svp_buffer_create
0000000000025fa0 T sa_svp_buffer_free
0000000000026084 T sa_svp_buffer_release
00000000000262c8 T sa_svp_buffer_write
0000000000026654 T sa_svp_key_check
00000000000257e0 T sa_svp_memory_alloc
0000000000025884 T sa_svp_memory_free
0000000000025764 T sa_svp_supported
0000000000046f54 T svp_copy
000000000005e7a4 t svp_create
0000000000046904 T svp_create_buffer
000000000004764c T svp_digest
000000000005e734 t svp_free
000000000005e9ac T svp_get_buffer
00000000000478d0 T svp_get_size
0000000000047854 T svp_get_svp_memory
0000000000047438 T svp_key_check
000000000005e8e0 t svp_lock
0000000000046a68 T svp_release_buffer
000000000005ef30 T svp_store_acquire_exclusive
000000000005ea9c T svp_store_create
000000000005ea00 T svp_store_init
000000000005ec74 T svp_store_release
000000000005f114 T svp_store_release_exclusive
000000000005ea6c T svp_store_shutdown
000000000005e72c T svp_supported
000000000005e94c t svp_unlock
0000000000046854 t svp_validate_buffer
0000000000046b68 T svp_write
000000000002e120 t ta_invoke_svp_buffer_check
000000000002da6c t ta_invoke_svp_buffer_copy
000000000002d314 t ta_invoke_svp_buffer_create
000000000002d4c0 t ta_invoke_svp_buffer_release
000000000002d6c8 t ta_invoke_svp_buffer_write
000000000002ddec t ta_invoke_svp_key_check
000000000002d194 t ta_invoke_svp_supported
00000000000428e0 T ta_sa_svp_buffer_check
0000000000042cb4 T ta_sa_svp_buffer_copy
0000000000042f70 T ta_sa_svp_buffer_create
0000000000043118 T ta_sa_svp_buffer_release
00000000000432f8 T ta_sa_svp_buffer_write
0000000000043574 T ta_sa_svp_key_check
00000000000428c8 T ta_sa_svp_supported

@harindhu007 harindhu007 force-pushed the feature/Issue_136 branch 2 times, most recently from 50e2071 to 4caf74a Compare July 21, 2025 09:03
mhabrat
mhabrat requested changes Jul 29, 2025
View reviewed changes
@harindhu007 harindhu007 force-pushed the feature/Issue_136 branch 6 times, most recently from 505a2c3 to 8ff96ee Compare September 29, 2025 20:06
@harindhu007 harindhu007 force-pushed the feature/Issue_136 branch 3 times, most recently from 469acf3 to 1988301 Compare October 14, 2025 23:09
mhabrat
mhabrat requested changes Nov 17, 2025
View reviewed changes
reference/src/taimpl/src/ta_sa_svp_supported.c Outdated
ta_client client_slot,
const sa_uuid* caller_uuid) {

#ifdef ENABLE_SVP
Copy link
Contributor

@mhabrat mhabrat Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be when SVP is not enabled?

@harindhu007 harindhu007 force-pushed the feature/Issue_136 branch 2 times, most recently from 69928ff to 84efbe9 Compare November 18, 2025 18:21
@harindhu007
Issue 136: Add a flag to Disable/Enable SVP functionality
b688f2b 
Reason for change: Disable/Enable SVP functionality using flag
Risks: None
Priority: P1
@riwoh riwoh merged commit 39e1f7d into rdkcentral:main Jan 17, 2026
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mhabrat mhabrat mhabrat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harindhu007 @mhabrat @riwoh