RDKB-63303, RDKB-63414, RDKB-63743 : Move RdkLogger Scripts to Cron#18
Merged
anoopchelakkode merged 1 commit intodevelopfrom Mar 4, 2026
Merged
RDKB-63303, RDKB-63414, RDKB-63743 : Move RdkLogger Scripts to Cron#18anoopchelakkode merged 1 commit intodevelopfrom
anoopchelakkode merged 1 commit intodevelopfrom
Conversation
Reason for change: Running the rdklogger scripts as cron jobs instead of background processes when the cron is enabled and running as normal background process when the cron is disabled. Test Procedure: Check scripts are running in crontab when the cron is enabled. Priority: P1 Risks: None Signed-off-by: KavyaChowdahalli_Suresh@comcast.com
9552b58 to
8a6ea3e
Compare
There was a problem hiding this comment.
Pull request overview
This PR moves RDKB log-monitoring/upload behavior toward a cron-driven execution model when RdkbLogCronEnable is enabled, while keeping the legacy long-running background process path when cron is disabled.
Changes:
- Added a new cron-oriented log monitor script (
rdkbLogMonitor_cron.sh) with state/locking to support minute-based execution. - Simplified
rdkbLogMonitor.shby removing the embedded cron-mode state machine and keeping it as the non-cron (background) implementation. - Updated
fileUploadRandom.shto add cron-mode locking and adjust when countdown state files are cleared.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rdkbLogMonitor_cron.sh | New cron-mode implementation with boot workflow state tracking, cron self-install, and cron-instance locking. |
| rdkbLogMonitor.sh | Removes cron-mode scaffolding and keeps background-loop behavior, with boot upload refactoring. |
| fileUploadRandom.sh | Adds cron-mode lockfile protection and adjusts countdown state cleanup timing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
snayak002c
approved these changes
Mar 4, 2026
anoopchelakkode
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Running the rdklogger scripts as cron jobs instead of background processes when the cron is enabled and running as normal background process when the cron is disabled.
Test Procedure: Check scripts are running in crontab when the cron is enabled.
Priority: P1
Risks: None
Signed-off-by: KavyaChowdahalli_Suresh@comcast.com