Skip to content

RDKB-63303, RDKB-63414, RDKB-63743 : Move RdkLogger Scripts to Cron#18

Merged
anoopchelakkode merged 1 commit intodevelopfrom
feature/rdklogger-cron
Mar 4, 2026
Merged

RDKB-63303, RDKB-63414, RDKB-63743 : Move RdkLogger Scripts to Cron#18
anoopchelakkode merged 1 commit intodevelopfrom
feature/rdklogger-cron

Conversation

@ksures101
Copy link
Contributor

Reason for change: Running the rdklogger scripts as cron jobs instead of background processes when the cron is enabled and running as normal background process when the cron is disabled.
Test Procedure: Check scripts are running in crontab when the cron is enabled.
Priority: P1
Risks: None

Signed-off-by: KavyaChowdahalli_Suresh@comcast.com

Copilot AI review requested due to automatic review settings March 4, 2026 16:26
@ksures101 ksures101 requested a review from a team as a code owner March 4, 2026 16:26
Reason for change: Running the rdklogger scripts as cron jobs instead of background processes when the cron is enabled and running as normal background process when the cron is disabled.
Test Procedure: Check scripts are running in crontab when the cron is enabled.
Priority: P1
Risks: None

Signed-off-by: KavyaChowdahalli_Suresh@comcast.com
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves RDKB log-monitoring/upload behavior toward a cron-driven execution model when RdkbLogCronEnable is enabled, while keeping the legacy long-running background process path when cron is disabled.

Changes:

  • Added a new cron-oriented log monitor script (rdkbLogMonitor_cron.sh) with state/locking to support minute-based execution.
  • Simplified rdkbLogMonitor.sh by removing the embedded cron-mode state machine and keeping it as the non-cron (background) implementation.
  • Updated fileUploadRandom.sh to add cron-mode locking and adjust when countdown state files are cleared.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
rdkbLogMonitor_cron.sh New cron-mode implementation with boot workflow state tracking, cron self-install, and cron-instance locking.
rdkbLogMonitor.sh Removes cron-mode scaffolding and keeps background-loop behavior, with boot upload refactoring.
fileUploadRandom.sh Adds cron-mode lockfile protection and adjusts countdown state cleanup timing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@anoopchelakkode anoopchelakkode merged commit aa37cbe into develop Mar 4, 2026
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants