RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management

[Vismalskumar0]

RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management

[Copilot]

Pull request overview

This PR appears to target Coverity findings in the RFC/XConf handler, focusing on memory handling, logging robustness, and minor efficiency tweaks in Device Management.

Changes:

• Added <errno.h> and refined IsDirectBlocked() to treat ENOENT as non-fatal when removing the direct-block file, while logging detailed errno information on failure.
• Reduced unnecessary string copies by using std::move when passing temporary or last-use std::string instances into helper methods and containers.
• Tightened memory management around hashParam_t in DownloadRuntimeFeatutres() by explicitly freeing nested heap-allocated members and nulling pointers, and made the cURL error telemetry switch exhaustive with break/default handling.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

hashParam and its inner allocations are only freed via file_dwnl.hashData on the main success path, but there are several earlier return paths in this function (e.g., MTLS cert failures, cert selector init failure, or the case where pDwnLoc->pvOut/pHeaderDwnLoc->pvOut are null) that exit without hitting this cleanup, leaking both the hashParam_t struct and any strdup-allocated strings. Consider centralizing cleanup (e.g., a single exit path with a cleanup block or a small RAII helper) so that hashParam->hashvalue, hashParam->hashtime, and hashParam are released consistently on all return paths, including error conditions and the !pDwnLoc->pvOut || !pHeaderDwnLoc->pvOut case.