Remove std::move() and enhance logging in clearDB()#155
Draft
Copilot wants to merge 4 commits intotopic/RDK-60308from
Draft
Remove std::move() and enhance logging in clearDB()#155Copilot wants to merge 4 commits intotopic/RDK-60308from
Copilot wants to merge 4 commits intotopic/RDK-60308from
Conversation
Co-authored-by: Vismalskumar0 <[email protected]>
Co-authored-by: Vismalskumar0 <[email protected]>
Co-authored-by: Vismalskumar0 <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on Coverity defect resolution for device management
Remove std::move() and enhance logging in clearDB()
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #143 regarding logging statements that became uninformative after std::move() operations.
Changes:
std::move()fromClearDBandBootstrapClearDBparameters inset_RFCProperty()calls (lines 1298-1299)Before:
After:
Move semantics provide minimal benefit for short-lived local string literals. Pattern now matches
clearDBEnd()function.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.