Skip to content

Topic/rdksysintsw_3598 _rfc #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vismalskumar0 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Topic/rdksysintsw_3598 _rfc #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6163893
Update rfc_xconf_handler.cpp
nhanasi Jan 7, 2026
3d5cbf9
Merge pull request #145 from rdkcentral/develop
Vismalskumar0 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rfcMgr/rfc_xconf_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2413,12 +2413,15 @@ void RuntimeFeatureControlProcessor::processXconfResponseConfigDataPart(JSON *fe
}
else
{

#if !defined(RDKB_SUPPORT)
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace/tabs at the end of this preprocessor directive line. Trailing whitespace can cause inconsistencies in code formatting and version control diffs.

Copilot uses AI. Check for mistakes.
if (newValue.empty())
{
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] EMPTY value for %s is rejected\n", __FUNCTION__, __LINE__, newKey.c_str());
continue;
}

#endif

Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line containing only whitespace/tabs. Empty lines with whitespace can cause code formatting inconsistencies and should be replaced with a truly blank line.

Copilot uses AI. Check for mistakes.
if(newKey == BOOTSTRAP_XCONF_URL_KEY_STR)
{
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Feature Name [%s] Current Value[%s] New Value[%s] \n", __FUNCTION__, __LINE__, newKey.c_str(), currentValue.c_str(), newValue.c_str());
Expand Down Expand Up @@ -2555,6 +2558,7 @@ bool RuntimeFeatureControlProcessor::isConfigValueChange(std ::string name, std
}
else
{
#if !defined(RDKB_SUPPORT)
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace/tabs at the end of this preprocessor directive line. Trailing whitespace can cause inconsistencies in code formatting and version control diffs.

Copilot uses AI. Check for mistakes.
std::string account_key_str = RFC_ACCOUNT_ID_KEY_STR;
std::string unknown_str = "Unknown";
bool isAccountKey = (key.find(account_key_str) != std::string::npos) ? true : false;
Expand All @@ -2576,7 +2580,7 @@ bool RuntimeFeatureControlProcessor::isConfigValueChange(std ::string name, std
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] AccountId is Valid %s, Updating the device Database\n", __FUNCTION__, __LINE__,value.c_str());
}
}

#endif
return true;
}

Expand Down
Loading