Skip to content

RDKBACCL-1402,RDKBACCL-1401,RDKBACCL-1400,RDKBACCL-1399,RDKBACCL-1398… #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anatar818 wants to merge 1 commit into
base: develop
Choose a base branch
from
+19 −7
Open

RDKBACCL-1402,RDKBACCL-1401,RDKBACCL-1400,RDKBACCL-1399,RDKBACCL-1398… #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions source/fwupgrade/fwupgrade_hal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
#define RETRY_DELAY 2
#define MAX_LINE 512
#define RETURN_OK 0
#define RETURN_ERR 1
#define RETURN_ERR -1
//#include "fwupgrade_hal.h"
#define HTTP_DWNLD_CONFIG_FILE "/tmp/httpDwnld.conf"
#define HTTP_DWNLD_IF_FILE "/tmp/httpDwnldIf.conf"
Expand Down Expand Up @@ -262,11 +262,17 @@ INT fwupgrade_hal_set_download_url (char* pUrl, char* pfilename)
{
fprintf(stderr,"Entering %s \n",__FUNCTION__);
// if ((pUrl == NULL) || (pfilename==NULL))
if ((pUrl == NULL) || (pfilename==NULL) || (strlen(pfilename) >= FILENAME_MAX_LENGTH) || (strlen(pUrl) >= URL_MAX_LENGTH))
if ((pUrl == NULL) || (pfilename==NULL))
{
fprintf(stderr,"%s: Buffer length was exceeding for HTTP URL - %d or filename - %d... \n", __func__, strlen(pUrl), strlen(pfilename));
fprintf(stderr,"%s: NULL Url or filename has been passed as the input -... \n", __func__);
return RETURN_ERR;
}
else if ( (strlen(pfilename) >= FILENAME_MAX_LENGTH) || (strlen(pUrl) >= URL_MAX_LENGTH) )
{
fprintf(stderr,"%s: Buffer length was exceeding for HTTP URL - %d or filename - %d... \n", __func__, strlen(pUrl), strlen(pfilename));
return RETURN_ERR;

}
else
{
FILE* fp;
Expand Down Expand Up @@ -318,11 +324,17 @@ Parameters : char* pfilename;
INT fwupgrade_hal_get_download_url (char *pUrl, char* pfilename)
{
//if ((pUrl == NULL) || (pfilename==NULL))
if ((pUrl == NULL) || (pfilename==NULL) || (strlen(pfilename) >= FILENAME_MAX_LENGTH) || (strlen(pUrl) >= URL_MAX_LENGTH))
if ((pUrl == NULL) || (pfilename==NULL))
{
fprintf(stderr,"%s: Buffer length was exceeding for HTTP URL - %d or filename - %d... \n", __func__, strlen(pUrl), strlen(pfilename));
return RETURN_ERR;
}
fprintf(stderr,"%s: NULL Url or filename has been passed as the input -... \n", __func__);
return RETURN_ERR;
}
else if ( (strlen(pfilename) >= FILENAME_MAX_LENGTH) || (strlen(pUrl) >= URL_MAX_LENGTH) )
{
fprintf(stderr,"%s: Buffer length was exceeding for HTTP URL - %d or filename - %d... \n", __func__, strlen(pUrl), strlen(pfilename));
return RETURN_ERR;

}
else
{
FILE* fp;
Expand Down