gh515 Add dsHost HAL init/term to SOB test suite#516
gh515 Add dsHost HAL init/term to SOB test suite#516hjourdain-ryvr wants to merge 1 commit intordkcentral:mainfrom
Conversation
test_l3_dsHost_hal_get_hostEdid is the only test in the SOB_Only test suite, but it needs to be called after dsHostInit() and before dsHostTerm(), otherwise it will return dsERR_NOT_INITIALIZED, and the test will fail. So add test_l3_dsHost_hal_Init and test_l3_dsHost_hal_Term to the SOB_Only test suite.
| UT_add_test( pSuite_SOB_Only, "Get Host EDID", test_l3_dsHost_hal_get_hostEdid); | ||
| UT_add_test( pSuite, "Terminate dsHost", test_l3_dsHost_hal_Term); | ||
|
|
||
| UT_add_test( pSuite_SOB_Only, "Initialize dsHost", test_l3_dsHost_hal_Init); |
There was a problem hiding this comment.
What does SOB mean? Since this is an L3 test, the order of test cases doesn’t matter because the host/Python script controls the execution sequence.
|
I have no idea what SOB means, it was the name of the test suite, I just added init/term to the existing test suite. |
|
|
||
| UT_add_test( pSuite_SOB_Only, "Initialize dsHost", test_l3_dsHost_hal_Init); | ||
| UT_add_test( pSuite_SOB_Only, "Get Host EDID", test_l3_dsHost_hal_get_hostEdid); | ||
| UT_add_test( pSuite_SOB_Only, "Terminate dsHost", test_l3_dsHost_hal_Term); |
There was a problem hiding this comment.
VTS L3 tests are independent and will be called from the host test (https://github.com/rdkcentral/rdk-halif-test-device_settings/blob/main/host/tests/L3_TestCases/dsHdmiIn/dsHdmiIn_test11_GetEDIDInfo_Verify.py) to perform the full functionality. The Init and Term are handled in the test script, where the test sequence from init to termination is defined. I don't see why you need to add it specifically here, instead of running the tests from the test folder.
test_l3_dsHost_hal_get_hostEdid is the only test in the SOB_Only test suite, but it needs to be called after dsHostInit() and before dsHostTerm(), otherwise it will return dsERR_NOT_INITIALIZED, and the test will fail. So add test_l3_dsHost_hal_Init and test_l3_dsHost_hal_Term to the SOB_Only test suite.