Skip to content

gh515 Add dsHost HAL init/term to SOB test suite#516

Open
hjourdain-ryvr wants to merge 1 commit intordkcentral:mainfrom
hjourdain-ryvr:gh515_l3_dshost_add_hal_init_term_to_sob_suite
Open

gh515 Add dsHost HAL init/term to SOB test suite#516
hjourdain-ryvr wants to merge 1 commit intordkcentral:mainfrom
hjourdain-ryvr:gh515_l3_dshost_add_hal_init_term_to_sob_suite

Conversation

@hjourdain-ryvr
Copy link

test_l3_dsHost_hal_get_hostEdid is the only test in the SOB_Only test suite, but it needs to be called after dsHostInit() and before dsHostTerm(), otherwise it will return dsERR_NOT_INITIALIZED, and the test will fail. So add test_l3_dsHost_hal_Init and test_l3_dsHost_hal_Term to the SOB_Only test suite.

test_l3_dsHost_hal_get_hostEdid is the only test in the SOB_Only test suite, but it needs to be called after dsHostInit() and before dsHostTerm(), otherwise it will return dsERR_NOT_INITIALIZED, and the test will fail. So add test_l3_dsHost_hal_Init and test_l3_dsHost_hal_Term to the SOB_Only test suite.
@hjourdain-ryvr hjourdain-ryvr changed the title Add dsHost HAL init/term to SOB test suite gh515 Add dsHost HAL init/term to SOB test suite Nov 11, 2025
UT_add_test( pSuite_SOB_Only, "Get Host EDID", test_l3_dsHost_hal_get_hostEdid);
UT_add_test( pSuite, "Terminate dsHost", test_l3_dsHost_hal_Term);

UT_add_test( pSuite_SOB_Only, "Initialize dsHost", test_l3_dsHost_hal_Init);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does SOB mean? Since this is an L3 test, the order of test cases doesn’t matter because the host/Python script controls the execution sequence.

@hjourdain-ryvr
Copy link
Author

I have no idea what SOB means, it was the name of the test suite, I just added init/term to the existing test suite.
Regarding the test suites, if you run them manually, you can select the test suite to run, then run all the tests in it automatically. I believe you can do the same with automated testing.
With this test suite, if you do that with the current order, then the test suite will fail, because init/term are not called, and the tests are not "self-contained" (they do not call the module init/term as part of the test).


UT_add_test( pSuite_SOB_Only, "Initialize dsHost", test_l3_dsHost_hal_Init);
UT_add_test( pSuite_SOB_Only, "Get Host EDID", test_l3_dsHost_hal_get_hostEdid);
UT_add_test( pSuite_SOB_Only, "Terminate dsHost", test_l3_dsHost_hal_Term);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VTS L3 tests are independent and will be called from the host test (https://github.com/rdkcentral/rdk-halif-test-device_settings/blob/main/host/tests/L3_TestCases/dsHdmiIn/dsHdmiIn_test11_GetEDIDInfo_Verify.py) to perform the full functionality. The Init and Term are handled in the test script, where the test sequence from init to termination is defined. I don't see why you need to add it specifically here, instead of running the tests from the test folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants