Skip to content

gh513 Change videodevice_term to last#514

Open
hjourdain-ryvr wants to merge 1 commit intordkcentral:mainfrom
hjourdain-ryvr:gh513_change_videodevice_term_to_last
Open

gh513 Change videodevice_term to last#514
hjourdain-ryvr wants to merge 1 commit intordkcentral:mainfrom
hjourdain-ryvr:gh513_change_videodevice_term_to_last

Conversation

@hjourdain-ryvr
Copy link

For the VideoDevice tests to be successful, they need to be run after videodevice_init and before videodevice_term. Currently, videodevice_term is called just after videodevice_init in the test suite. Move it to the last position.

For the VideoDevice tests to be successful, they need to be run after videodevice_init and before videodevice_term.
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@hjourdain-ryvr
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@hjourdain-ryvr hjourdain-ryvr changed the title Change videodevice_term to last gh513 Change videodevice_term to last Nov 11, 2025
UT_add_test( pSuite, "SetZoomMode", test_l3_dsVideoDevice_SetZoomMode);
UT_add_test( pSuite, "GetZoomMode", test_l3_dsVideoDevice_dsGetZoomMode);
UT_add_test( pSuite, "GetVideoCodecInfo", test_l3_dsVideoDevice_GetVideoCodecInfo);
UT_add_test( pSuite, "VideoDevice_Term", test_l3_dsVideoDevice_Term);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an L3 test, the order of test cases doesn’t matter because the host/Python script controls the execution sequence

@hjourdain-ryvr
Copy link
Author

If you run the test suites manually, you can select the test suite to run, then run all the tests in it automatically. I believe you can do the same with automated testing.
With this test suite, if you do that with the current order, then the test suite will fail, because term is called before some of the tests in the test suite are run, therefore the tests after that in the test suite will not be initialized - and the tests are not "self-contained" (they do not call the module init/term as part of the test).

@srinivasgtl
Copy link
Contributor

The purpose of the VTS is also to provide a scope for the developer who may need to debug. The L3 tests can run in steps if required by selecting the init, any action-related api, and term in the necessary sequence. If we need to run this in automation, we also use the tests available in tests, which are already sequenced. Refer to https://github.com/rdkcentral/rdk-halif-test-device_settings/tree/main/host/tests/L3_TestCases/dsVideoDevice for the tests in sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants