RDKB-62810,RDKB-62812:Create Virtual Interface for voice and initialize DHCP#168
RDKB-62810,RDKB-62812:Create Virtual Interface for voice and initialize DHCP#168snayak002c merged 15 commits intordkcentral:developfrom
Conversation
Reason for change:Added the new entry for virual mta interface Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:Added the new entry for virual mta interface Test Procedure: verify the logic and functionality Risks: Low Priority: P1
There was a problem hiding this comment.
Pull request overview
This pull request adds support for EPON-based voice interface (MTA) configuration by introducing three new device parameters to the Comcast partner defaults configuration file. The change enables voice support functionality with an "mta0" interface configured for IPv4-only mode.
Changes:
- Added three new EPON MTA voice support configuration parameters to the Comcast partner section
- Configured voice support as enabled by default with interface name "mta0" and IPv4-only mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Device.X_RDKCENTRAL-COM_Epon_MTA.VoiceSupport.Enabled" : "true", | ||
| "Device.X_RDKCENTRAL-COM_Epon_MTA.VoiceSupport.InterfaceName" : "mta0", | ||
| "Device.X_RDKCENTRAL-COM_Epon_MTA.VoiceSupport.Mode" : "IPv4_Only", |
There was a problem hiding this comment.
The naming pattern "X_RDKCENTRAL-COM_Epon_MTA" is inconsistent with the existing pattern "X_RDKCENTRAL-COM_EthernetWAN_MTA" used in lines 60-64. Consider using a consistent naming convention throughout the configuration file, either following the existing pattern or documenting why a different pattern is necessary for EPON-based MTA configurations.
Amaresh-Kotekal
changed the title
|
Is this a Bug or a User Story (US)? If it is a User Story: Please list all dependent PRs from other components, if any. The commit message must include both the User Story ticket and the Subtask ticket --> addressed All changes related to the User Story must be squashed and merged in a single commit. Do not raise pull requests for partial User Story changes. Has the code development for the User Story been completed? --> Not yet If yes, please share the Gerrit topic or list all dependent PRs across components, including any meta-layer changes. If yes, please share the links to the validation comments. |
Reason for change:Added the new entry for virual mta interface Test Procedure: verify the logic and functionality Risks: High Priority: P1
Amaresh-Kotekal
force-pushed
the
develop
branch
from
12f7d03 to
92fdc20
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Device.X_RDKCENTRAL-COM_EthernetWAN_MTA.IPv4SecondaryDhcpServerOptions" : "FFFFFFFF", | ||
| "Device.X_RDKCENTRAL-COM_EthernetWAN_MTA.IPv6PrimaryDhcpServerOptions" : "FFFFFFFF", | ||
| "Device.X_RDKCENTRAL-COM_EthernetWAN_MTA.IPv6SecondaryDhcpServerOptions" : "FFFFFFFF", | ||
| "Device.X_RDKCENTRAL-COM_Epon_MTA.VoiceSupport.Enabled" : "true", |
There was a problem hiding this comment.
The key Device.X_RDKCENTRAL-COM_Epon_MTA.VoiceSupport.Enabled is the only .Enabled boolean-style parameter in this file; existing boolean flags here consistently use .Enable/Enable* naming. If the underlying TR-181/PSM parameter is actually ...VoiceSupport.Enable (or similar), this entry will be ignored and voice support won’t be enabled. Please verify the exact parameter name expected by the data model and align the key accordingly.
| "Device.X_RDKCENTRAL-COM_Epon_MTA.VoiceSupport.Enabled" : "true", | |
| "Device.X_RDKCENTRAL-COM_Epon_MTA.VoiceSupport.Enable" : "true", |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Reason for change:Added the new entry for voice support
Test Procedure: verify the new voice interface creation functionality
Risks: High
Priority: P1