RDKEMW-13125: Wi‑Fi in the picker are not ordered by signalstrength

[gururaajar]

Reason for change: Updated the onAvailableSSID to return strength and frequency as numbers so that the UI will do the sorting.
Test Procedure: Check the onAvailableSSID returns strength and frequency as numbers
Priority:P1
Risks: Medium

[Copilot]

Pull request overview

This PR updates the NetworkManager Wi‑Fi APIs/events to emit signal strength, noise/SNR, rate, and frequency as numeric types (instead of strings) so the UI can correctly sort SSIDs by signal strength.

Changes:

• Converted WiFi signal quality and connected-SSID fields from strings to numeric types across the COM-RPC interface, JSON-RPC responses, and event payloads.
• Updated GNOME (libnm/gdbus) and RDK proxy implementations to populate numeric strength/frequency and adjusted logging accordingly.
• Updated schema/docs and L2/unit tests to match the new numeric JSON shapes.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/plugincli/NetworkManagerLibnmTest.cpp	Adjusted test callback signature to use numeric signal params.
tools/plugincli/NetworkManagerGdbusTest.cpp	Updated CLI test to use int signal strength and numeric logging.
tests/mocks/INetworkManagerMock.h	Updated mock method signature for numeric signal quality outputs.
tests/l2Test/rdk/l2_test_rdkproxy.cpp	Updated expected JSON to numeric strength/frequency/rate/noise.
tests/l2Test/libnm/l2_test_libnmproxyWifi.cpp	Updated expected JSON to numeric strength/frequency/rate/noise (including disconnected case).
tests/l2Test/legacy/l2_test_LegacyPlugin_WiFiManagerAPIs.cpp	Updated legacy test data to populate numeric fields in WiFiSSIDInfo.
plugin/rdk/NetworkManagerRDKProxy.cpp	Remapped available-SSID event objects to the new numeric strength/frequency fields; updated connected SSID info typing.
plugin/gnome/gdbus/NetworkManagerGdbusUtils.h / .cpp	Switched strength conversion helper to return int; made frequency/rate/noise numeric.
plugin/gnome/gdbus/NetworkManagerGdbusClient.h / .cpp	Updated signal quality getter to use numeric strength and avoid string parsing.
plugin/gnome/NetworkManagerGnomeWIFI.cpp	Made frequency/rate/noise/strength numeric and updated logs.
plugin/gnome/NetworkManagerGnomeUtils.h / .cpp	Updated helpers to return numeric signal strength and numeric frequency band.
plugin/gnome/NetworkManagerGnomeEvents.cpp	Emitted numeric strength/frequency in scan results.
plugin/NetworkManagerJsonRpc.cpp	Returned numeric strength/frequency/rate/noise and numeric signal quality fields in JSON-RPC.
plugin/NetworkManagerImplementation.h / .cpp	Updated GetWiFiSignalQuality and notification plumbing to use numeric outputs.
plugin/NetworkManager.h	Updated notification interface implementation to new numeric callback signature.
legacy/LegacyWiFiManagerAPIs.cpp	Converted connected-SSID legacy response fields to strings from new numeric data; adjusted SSID event remapping.
interface/INetworkManager.h	Changed WiFiSSIDInfo fields and GetWiFiSignalQuality signature to numeric; modified notification interface signatures.
docs/NetworkManagerPlugin.md	Updated documentation types/examples to numeric values.
definition/NetworkManager.json	Updated JSON schema types/examples to numeric values.

Comments suppressed due to low confidence (1)

plugin/NetworkManagerImplementation.cpp:947

• The RSSI clamp updates readRssi but does not update the returned strength value. As a result, callers can still receive an out-of-range RSSI even though the log says it was reset/clamped. After clamping, assign the clamped value back to strength (and keep any dependent calculations consistent).

            /* Check the RSSI is within range between -10 and -100 dbm*/
            if (readRssi >= 0 || readRssi < -100) {
                NMLOG_WARNING("Received RSSI (%d dBm) is out of valid range (-10 to -100 dBm); Resetting to default", readRssi);
                if (readRssi >= 0) {
                    readRssi = -10;
                }
                else if (readRssi < -100) {
                    readRssi = -100;
                }
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.