Skip to content

[RDK-E]: NetworkconnectionRecovery.sh migration to C/C++ Module #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
udaykrishnag wants to merge 13 commits into
base: develop
Choose a base branch
from
+4,668 −0
Open

[RDK-E]: NetworkconnectionRecovery.sh migration to C/C++ Module #274

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
08dd34c
RDK-59986 : NetworkconnectionRecovery.sh migration to C/C++ Module
Dec 10, 2025
ce7a8c7
RDK-59986 : NetworkconnectionRecovery.sh migration to C/C++ Module
Dec 10, 2025
8a6412e
Initial Skeleton.
Dec 10, 2025
24d19c1
Initial Skeleton.
Dec 10, 2025
11098ba
Update 1
Dec 10, 2025
3d487e3
Update NetworkConnectionStats.h
udaykrishnag Dec 10, 2025
2b39dac
Merge branch 'develop' into topic/RDK-59986
Jan 15, 2026
9708046
Merge branch 'develop' into topic/RDK-59986
Jan 27, 2026
bd40724
Merge branch 'develop' into topic/RDK-59986
Jan 29, 2026
b705641
Merge branch 'develop' into topic/RDK-59986
Jan 30, 2026
74dd5cb
Merge branch 'develop' into topic/RDK-59986
Feb 11, 2026
e6c6ff2
Merge branch 'develop' into topic/RDK-59986
Feb 12, 2026
c555c21
Apply suggestions from code review
udaykrishnag Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ get_directory_property(SEVICES_DEFINES COMPILE_DEFINITIONS)
option(ENABLE_LEGACY_PLUGINS "Enable Legacy Plugins" ON)
option(USE_RDK_LOGGER "Enable RDK Logger for logging" OFF )
option(ENABLE_UNIT_TESTING "Enable unit tests" OFF)
option(USE_TELEMETRY "Enable Telemetry support for NetworkConnectionStats" ON)
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This top-level option introduces USE_TELEMETRY defaulting to ON. USE_TELEMETRY is also used by other targets in this repo (e.g., tools/upnp), so this change will implicitly enable telemetry (and add a hard dependency on T2) beyond NetworkConnectionStats. Consider defaulting this option to OFF, or using a more scoped option name (e.g., NETWORKSTATS_USE_TELEMETRY) to avoid changing behavior of unrelated components.

Copilot uses AI. Check for mistakes.

Comment on lines +57 to 58
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USE_TELEMETRY defaults to ON, but networkstats/plugin/CMakeLists.txt uses find_package(T2 REQUIRED) when this is enabled. This makes a default build fail in environments without the T2 dependency. Consider defaulting USE_TELEMETRY to OFF (or making T2 optional/QUIET with a clear message) to keep the baseline build working.

Copilot uses AI. Check for mistakes.

add_subdirectory(interface)
Expand All @@ -64,6 +65,8 @@ if (ENABLE_LEGACY_PLUGINS)
add_subdirectory(legacy)
endif (ENABLE_LEGACY_PLUGINS)

add_subdirectory(networkstats)

add_subdirectory(tools)

if(ENABLE_UNIT_TESTING)
Expand Down
37 changes: 37 additions & 0 deletions networkstats/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#############################################################################
# If not stated otherwise in this file or this component's LICENSE file the
# following copyright and licenses apply:
#
# Copyright 2025 RDK Management
#
# Licensed under the Apache License, Version 2.0 (the "License");

Check failure on line 7 in networkstats/CMakeLists.txt

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'GPL-2.0' license found in local file 'networkstats/CMakeLists.txt' (Match: Mellanox/hw-mgmt/7.0040.112, 11 lines, url: https://github.com/Mellanox/hw-mgmt/archive/refs/tags/V.7.0040.112.tar.gz, file: usr/usr/bin/hw_management_redfish_client.py)
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#############################################################################
cmake_minimum_required(VERSION 3.3)

project(NetworkConnectionStats)

find_package(WPEFramework QUIET CONFIG)

message("Building ${PROJECT_NAME} Thunder Plugin (Internal-only, no external APIs)")

# Set project version
set(PROJECT_VERSION ${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH})

# Build interface (ProxyStub generation)
add_subdirectory(interface)

# Build definition (JSON-RPC documentation)
#add_subdirectory(definition)

# Build plugin
add_subdirectory(plugin)
Loading
Loading