Skip to content

RDKOSS-602: RDKE][Middleware][All components] Use IPK instead of build from source #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shalini1516 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDKOSS-602: RDKE][Middleware][All components] Use IPK instead of build from source #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions conf/distro/rdk.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,3 +389,23 @@ PREFERRED_PROVIDER_virtual/ca-certificates-trust-store ?= "ca-certificates-trust
PREFERRED_PROVIDER_virtual/firebolt ?= "ripple"

include conf/distro/rdk-cpc.conf
#MW IPK MODE
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment style here uses a single '#' at the beginning of the line. While this is technically valid, the file contains other section comments (like lines 56-58) that use a more structured format with separator lines. Consider using a more consistent comment format to match the rest of the file, or at least add a blank line before this comment to visually separate the new IPK MODE sections from the previous content.

Copilot uses AI. Check for mistakes.
RDK_MW_ARCH ??= "${MACHINE}"

MIDDLEWARE_ARCH = "${RDK_MW_ARCH}-middleware"
STACK_LAYER_EXTENSION = "${MIDDLEWARE_ARCH}"
RELEASE_NUM = "8.4.1.0"
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RELEASE_NUM is hardcoded to a specific version "8.4.1.0". This should use the ?= operator instead of = to allow it to be overridden by local.conf or other configuration files. Hardcoding the release number makes it difficult to work with different release versions without modifying the distro configuration.

Suggested change
RELEASE_NUM = "8.4.1.0"
RELEASE_NUM ?= "8.4.1.0"

Copilot uses AI. Check for mistakes.

Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable 'RDK_ARTIFACTS_BASE_URL' is referenced but never defined in this file or elsewhere in the codebase. This variable needs to be defined or set as a default value (using ?= operator), otherwise the IPK server paths will be incomplete and package fetching will fail.

Suggested change
RDK_ARTIFACTS_BASE_URL ?= ""

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable 'BUILD_VARIANT' is referenced but never defined in this file or elsewhere in the codebase. This variable needs to be defined or set as a default value (using ?= operator), otherwise the IPK server paths will be incomplete and package fetching will fail.

Suggested change
BUILD_VARIANT ?= "default"

Copilot uses AI. Check for mistakes.
MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}"
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"
IPK_FEED_URIS += " \
${STACK_LAYER_EXTENSION}##${MW_IPK_SERVER_PATH} "

Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains tab characters for indentation instead of spaces. The rest of the file uses spaces for indentation. This inconsistency could cause issues with Yocto/BitBake parsing and should be replaced with spaces to match the file's convention.

Suggested change

Copilot uses AI. Check for mistakes.
#OSS IPK MODE
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function 'get_oss_arch' is called here but is not defined anywhere in the codebase. This will cause a build error when BitBake evaluates this variable. You need to either define this function in a Python block or use an existing variable instead.

Suggested change
#OSS IPK MODE
#OSS IPK MODE
def get_oss_arch(d):
"""
Return the architecture string used for OSS middleware packages.
Prefer RDK_MW_ARCH if set, otherwise fall back to TARGET_ARCH,
and finally to 'all' as a safe generic default.
"""
arch = d.getVar('RDK_MW_ARCH')
if arch:
return arch
arch = d.getVar('TARGET_ARCH')
if arch:
return arch
return 'all'

Copilot uses AI. Check for mistakes.
MW_EXTENSION = "-middleware"
MW_OSS = "${@get_oss_arch(d)}${MW_EXTENSION}"
STACK_LAYER_EXTENSION += " ${MW_OSS}"
OPKG_ARCH_PRIORITY:${MW_OSS} = "205"
MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}"
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"
IPK_FEED_URIS += " ${MW_OSS}##${MW_OSS_IPK_SERVER_PATH} "