Open
Conversation
nhanasi
changed the title
AravindanNC
approved these changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts changes from PR #430 that enabled RDM Support on RDKE Builds. The revert adds back explicit file packaging declarations for the MemCapture binary in the BitBake recipe.
Key Changes:
- Re-introduces the
FILES:${PN}variable declaration to explicitly include the MemCapture binary in the package
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+35
| FILES:${PN} += "${bindir}/MemCapture \ | ||
| " |
There was a problem hiding this comment.
The trailing backslash on line 34 is unnecessary since there are no additional continuation lines after line 35. This creates maintainability issues as it suggests more content should follow when none does. Remove the backslash from line 34 or remove the empty continuation line 35 entirely.
Suggested change
| FILES:${PN} += "${bindir}/MemCapture \ | |
| " | |
| FILES:${PN} += "${bindir}/MemCapture" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDK-60130: Reverting untill the image support is good