RDKEMW-13366: Move game controller database to middleware layer#346
Open
ganeshprasads wants to merge 1 commit intodevelopfrom
Open
RDKEMW-13366: Move game controller database to middleware layer#346ganeshprasads wants to merge 1 commit intodevelopfrom
ganeshprasads wants to merge 1 commit intodevelopfrom
Conversation
12 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Yocto packaging for libmanette to remove the bundled game controller database from the OSS-layer libmanette recipe, aligning with the stated goal of managing the database from the middleware (MW) layer instead.
Changes:
- Removed
gamecontrollerdbfromlibmanette_0.2.6.bbSRC_URIanddo_install()so it’s no longer installed/packaged bylibmanette. - Deleted
recipes-extended/libmanette/libmanette/gamecontrollerdbfrom this layer.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| recipes-extended/libmanette/libmanette_0.2.6.bb | Stops fetching/installing/packaging the controller DB as part of libmanette. |
| recipes-extended/libmanette/libmanette/gamecontrollerdb | Removes the controller mapping DB file from this layer. |
Comments suppressed due to low confidence (1)
recipes-extended/libmanette/libmanette_0.2.6.bb:17
- PR description says the game controller database was “moved to MW layer”, but this PR only removes it from the
libmanetterecipe and deletes the file; there’s no corresponding addition of a new provider recipe or dependency wiring in this repo. If the actual move happens in a different repo/PR, please reference it here (or include the new MW-layer recipe changes) so it’s clear how the DB will continue to be delivered to images.
SRC_URI = "https://download.gnome.org/sources/libmanette/0.2/libmanette-${PV}.tar.xz \
file://0001-old-kernel-and-64-bit-kernel-build-error-fix.patch \
file://0001-send-event-in-thread-context.patch \
file://0001-default-gamepad-db-dir-usr-share.patch \
file://0001-new-SDL-gamedb.patch \
file://0002-add-wayland-inputfd-support.patch \
file://0001-map-key-menu-back-as-btn.patch \
file://0003-button-values-for-gas-brake.patch \
file://0001-nintendo-digital-trigger-dpad-fix.patch \
file://0001-nintendo-joycon-L-R-detect.patch \
file://99-gamepad-set-attr.rules \
"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goruklu
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Removed gamepad database from libmanette recipe and moved to MW layer for ease of management.
Test Procedure: Verify functionality with gamepad test app
Risks: Low
Priority: P2
Signed-off-by: Ganesh prasad Sahu GaneshPrasad_Sahu@comcast.com