RDKEMW-12035: [RDKAppManagers] Add support for reading yaml files#345
RDKEMW-12035: [RDKAppManagers] Add support for reading yaml files#345
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the YAML C++ runtime dependency to the OSS layer package set so images built with this layer include yaml-cpp, supporting components that need to read YAML at runtime.
Changes:
- Add
yaml-cppto thepackagegroup-oss-layerruntime dependencies. - Register
yaml-cpppackage revision and architecture settings inpackage_revisions_oss.inc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-oss-layer.bb | Adds yaml-cpp to the OSS layer packagegroup runtime dependencies. |
| conf/include/package_revisions_oss.inc | Adds PR/PACKAGE_ARCH entries for pn-yaml-cpp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| xmlsec1 \ | ||
| yajl \ | ||
| zstd \ | ||
| yaml-cpp \ | ||
| " |
There was a problem hiding this comment.
RDEPENDS:${PN} list in this section appears to be kept in alphabetical order (e.g., xmlsec1, yajl, zstd). yaml-cpp is currently placed after zstd, which breaks the ordering and makes future maintenance/search harder. Consider moving yaml-cpp to be adjacent to the other ya* entries (e.g., after yajl and before zstd).
| PR:pn-zstd ?= "r0" | ||
| PACKAGE_ARCH:pn-zstd ?= "${OSS_LAYER_ARCH}" | ||
|
|
||
| PR:pn-yaml-cpp ?= "r0" | ||
| PACKAGE_ARCH:pn-yaml-cpp ?= "${OSS_LAYER_ARCH}" |
There was a problem hiding this comment.
This PR/PACKAGE_ARCH block is sorted alphabetically by pn-* in the surrounding context (…pn-xz, pn-yajl, pn-zlib, pn-zstd). The new pn-yaml-cpp entries are appended after pn-zstd, which breaks that ordering. Please move PR:pn-yaml-cpp / PACKAGE_ARCH:pn-yaml-cpp to the correct position near the other pn-ya* entries (e.g., after pn-yajl and before pn-zlib).
1 participant
No description provided.