RDK-60130 : [RDKE] Enable RDM Support on RDKE Builds#313
RDK-60130 : [RDKE] Enable RDM Support on RDKE Builds#313
Conversation
Remove comcast-package-deploy.bbclass
There was a problem hiding this comment.
Pull request overview
This pull request proposes to remove the comcast-package-deploy.bbclass file, claiming it is no longer used. However, this change introduces critical breaking issues as multiple active recipes and classes across the codebase still depend on this class for RDM (Runtime Download Manager) functionality.
Key Changes:
- Complete removal of
comcast-package-deploy.bbclass(139 lines deleted)
Comments suppressed due to low confidence (1)
classes/comcast-package-deploy.bbclass:1
- Removing this class will break multiple recipes and classes that depend on it. The following files currently inherit or reference
comcast-package-deploy:
classes/ptest-package-deploy.bbclass- conditionally inherits this classrecipes-connectivity/bind/bind_%.bbappend- directly inherits this class (line 71)recipes-core/systemd/systemd_250.%.bbappend- directly inherits this class (line 19)recipes-devtools/gdb/gdb_%.bbappend- conditionally inherits this classrecipes-devtools/strace/strace_%.bbappend- conditionally inherits this classrecipes-extended/lsof/lsof_%.bbappend- conditionally inherits this classrecipes-extended/ltp/ltp_%.bbappend- conditionally inherits this class (line 10)recipes-support/binutils/binutils_%.bbappend- conditionally inherits this classrecipes-support/gperftools/gperftools_%.bbappend- conditionally inherits this class
These recipes depend on the RDM (Runtime Download Manager) functionality provided by this class, including the deploy_rdm_package function and copy_rdm_package function. Removing this class without updating these dependent recipes will cause build failures when RDM-related DISTRO_FEATURES are enabled. You must either update all dependent recipes to remove the inheritance statements or provide an alternative implementation before removing this class.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RDK-60130 : Remove comcast-package-deploy.bbclass as this is not used anymore