Skip to content

RDK-60130 : [RDKE] Enable RDM Support on RDKE Builds#313

Open
nhanasi wants to merge 1 commit intodevelopfrom
feature/RDK-60130
Open

RDK-60130 : [RDKE] Enable RDM Support on RDKE Builds#313
nhanasi wants to merge 1 commit intodevelopfrom
feature/RDK-60130

Conversation

@nhanasi
Copy link

@nhanasi nhanasi commented Dec 11, 2025

RDK-60130 : Remove comcast-package-deploy.bbclass as this is not used anymore

Remove comcast-package-deploy.bbclass
@nhanasi nhanasi requested a review from a team as a code owner December 11, 2025 17:43
Copilot AI review requested due to automatic review settings December 11, 2025 17:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request proposes to remove the comcast-package-deploy.bbclass file, claiming it is no longer used. However, this change introduces critical breaking issues as multiple active recipes and classes across the codebase still depend on this class for RDM (Runtime Download Manager) functionality.

Key Changes:

  • Complete removal of comcast-package-deploy.bbclass (139 lines deleted)
Comments suppressed due to low confidence (1)

classes/comcast-package-deploy.bbclass:1

  • Removing this class will break multiple recipes and classes that depend on it. The following files currently inherit or reference comcast-package-deploy:
  1. classes/ptest-package-deploy.bbclass - conditionally inherits this class
  2. recipes-connectivity/bind/bind_%.bbappend - directly inherits this class (line 71)
  3. recipes-core/systemd/systemd_250.%.bbappend - directly inherits this class (line 19)
  4. recipes-devtools/gdb/gdb_%.bbappend - conditionally inherits this class
  5. recipes-devtools/strace/strace_%.bbappend - conditionally inherits this class
  6. recipes-extended/lsof/lsof_%.bbappend - conditionally inherits this class
  7. recipes-extended/ltp/ltp_%.bbappend - conditionally inherits this class (line 10)
  8. recipes-support/binutils/binutils_%.bbappend - conditionally inherits this class
  9. recipes-support/gperftools/gperftools_%.bbappend - conditionally inherits this class

These recipes depend on the RDM (Runtime Download Manager) functionality provided by this class, including the deploy_rdm_package function and copy_rdm_package function. Removing this class without updating these dependent recipes will cause build failures when RDM-related DISTRO_FEATURES are enabled. You must either update all dependent recipes to remove the inheritance statements or provide an alternative implementation before removing this class.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments