Skip to content

RDKMVE-1815: add support for populating DAC AppStore URL in RFC from DAC_APPSTORE_URL #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arun-madhavan-013 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RDKMVE-1815: add support for populating DAC AppStore URL in RFC from DAC_APPSTORE_URL #93

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e4650c
RDKMVE-1815: add support for populating DAC AppStore URL in RFC from …
arun-madhavan-013 Feb 27, 2026
ce5b6e7
RDKMVE-1815: add a warning in build log if DAC_APPSTORE_URL is unset
arun-madhavan-013 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions classes/rdkv-community-configs.bbclass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ install_community_rfc_configs() {
if [ -f "${MANIFEST_PATH_RDK_IMAGES}/conf/community-rfc-configs.ini" ]; then
bbnote "Installing community RFC configs..."
install -D -m 0644 ${MANIFEST_PATH_RDK_IMAGES}/conf/community-rfc-configs.ini ${IMAGE_ROOTFS}/etc/rfcdefaults/community-rfc-configs.ini
if [ -n "${DAC_APPSTORE_URL}" ]; then
echo "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.DAC.ConfigURL=${DAC_APPSTORE_URL}" >> ${IMAGE_ROOTFS}/etc/rfcdefaults/community-rfc-configs.ini
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DAC_APPSTORE_URL variable is used directly in the echo command without validation or quoting. If the URL contains special shell characters (like semicolons, pipes, backticks, or dollar signs), this could lead to command injection or malformed configuration. Consider validating the URL format or properly quoting the variable expansion to prevent potential security issues.

Suggested change
echo "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.DAC.ConfigURL=${DAC_APPSTORE_URL}" >> ${IMAGE_ROOTFS}/etc/rfcdefaults/community-rfc-configs.ini
# Validate DAC_APPSTORE_URL to avoid unsafe shell characters that could trigger command substitution.
if printf '%s' "${DAC_APPSTORE_URL}" | grep -q '[$`]' ; then
bbwarn "DAC_APPSTORE_URL contains unsafe characters (\$ or \`). Skipping DAC configuration."
else
printf 'Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.DAC.ConfigURL=%s\n' "${DAC_APPSTORE_URL}" >> ${IMAGE_ROOTFS}/etc/rfcdefaults/community-rfc-configs.ini
fi

Copilot uses AI. Check for mistakes.
Comment on lines 25 to +27
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appends to the configuration file without ensuring the file ends with a newline. If the source file community-rfc-configs.ini doesn't end with a newline, the appended line will be concatenated to the last line of the file, potentially creating an invalid configuration. Consider adding a newline before appending, or checking if the file ends with a newline first.

Suggested change
install -D -m 0644 ${MANIFEST_PATH_RDK_IMAGES}/conf/community-rfc-configs.ini ${IMAGE_ROOTFS}/etc/rfcdefaults/community-rfc-configs.ini
if [ -n "${DAC_APPSTORE_URL}" ]; then
echo "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.DAC.ConfigURL=${DAC_APPSTORE_URL}" >> ${IMAGE_ROOTFS}/etc/rfcdefaults/community-rfc-configs.ini
config_file=${IMAGE_ROOTFS}/etc/rfcdefaults/community-rfc-configs.ini
install -D -m 0644 ${MANIFEST_PATH_RDK_IMAGES}/conf/community-rfc-configs.ini "${config_file}"
if [ -n "${DAC_APPSTORE_URL}" ]; then
# Ensure the config file ends with a newline before appending
if [ -s "${config_file}" ] && [ -n "$(tail -c1 "${config_file}" 2>/dev/null)" ]; then
echo >> "${config_file}"
fi
echo "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.DAC.ConfigURL=${DAC_APPSTORE_URL}" >> "${config_file}"

Copilot uses AI. Check for mistakes.
fi
fi
}

Expand Down