RDKBACCL-1209: Need to align the vendor wifi hal for bpi platform#387
RDKBACCL-1209: Need to align the vendor wifi hal for bpi platform#387ap934 wants to merge 1 commit intordkcentral:developfrom
Conversation
| POINTER_CHECK(output_ulong != NULL); | ||
| //zqiu:TODO:save config | ||
|
|
||
| if (radioIndex == 0) |
There was a problem hiding this comment.
I think, if condition block is not needed .
you can directly passed radioIndex instaed of apIndex in line no 250
There was a problem hiding this comment.
Updated by passing radioIndex directly.
|
|
||
|
|
||
| //Get the running channel number | ||
| INT wifi_getRadioChannel(INT radioIndex,ULONG *output_ulong) //RDKB |
There was a problem hiding this comment.
Is this api needed ? if yes, please add the logic to get the channel value
There was a problem hiding this comment.
Yes needed, added logic for getting channel
| @@ -0,0 +1,975 @@ | |||
| /* | |||
There was a problem hiding this comment.
Is that validation is done completely for non-em , em and wifi agent builds?
Also ,ensure below functional test cases also works as expected
- Associated clients info
- Stats of connected, radio and ssid
There was a problem hiding this comment.
All test cases passed and attached in ticket.
ap934
force-pushed
the
align_vendor_hal_onewifi
branch
from
6f29216 to
b92eb79
Compare
| do_install_append(){ | ||
| install -d ${D}/usr/bin | ||
| install -m 777 ${B}/wifihal ${D}/usr/bin/ | ||
| cp ${WORKDIR}/wifi_hal.c ${S}/wifi_hal.c |
There was a problem hiding this comment.
Use install instead of cp.
There was a problem hiding this comment.
Currently file is not in use
ap934
force-pushed
the
align_vendor_hal_onewifi
branch
3 times, most recently
from
8eeeba2 to
788360a
Compare
|
|
||
| require conf/distro/include/rdk-bpi.inc | ||
| PREFERRED_PROVIDER_hal-wifi_onewifi = "hal-wifi-generic" | ||
| PREFERRED_PROVIDER_hal-wifi_onewifi = "rdk-wifi-hal" |
There was a problem hiding this comment.
I think, this line is not needed ..
PREFERRED_PROVIDER_hal-wifi will be set like hal-wifi-generic , hal-wiif-mt76 like that
ap934
force-pushed
the
align_vendor_hal_onewifi
branch
from
788360a to
cc8f681
Compare
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/93b1b7e32d9c632994fc3a33aa1c9f76 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/af6b391e15a4f8c39554f6f8ad1709ef |
cpokuru
left a comment
cpokuru
left a comment
There was a problem hiding this comment.
will take it further once below change merged
rdkcentral/rdk-wifi-hal#547
ap934
force-pushed
the
align_vendor_hal_onewifi
branch
from
e407faf to
e53aeef
Compare
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/8fed16caf22f2ae8e572bb6cca46e552 |
Reason for change: Aligning vendor hal for bpi platform by removing onewifi flags and wifiagent references Test Procedure: Build should pass and Onewifi functionality should work without failure Risks:Medium Signed-off-by: ap934 <ap934@cable.comcast.com>
ap934
force-pushed
the
align_vendor_hal_onewifi
branch
from
e53aeef to
777f48a
Compare
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/21ba8ab6756373b8430e12d2ae606d16 |
5 participants
Reason for change: Aligning vendor hal for bpi platform by removing onewifi flags and wifiagent references
Test Procedure: Build should pass and Onewifi functionality should work without failure
Risks:Medium