Conversation
cpokuru
commented
Oct 31, 2025
cpokuru
commented
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Matter protocol support to the RDK MTK BPIR4 platform, including Thread and Bluetooth connectivity for smart home device integration. The changes span kernel configuration, firmware packages, service configurations, and application-level Matter implementation.
- Adds Matter SDK integration with custom ZAP configuration and device attestation
- Integrates OpenThread Border Router (OTBR) and Co-Processor Communication Daemon (CPCD) for Thread networking
- Enables Bluetooth support through CPC HCI bridge and firmware packages
- Configures kernel support for IEEE 802.15.4, Bluetooth, and necessary networking features
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| barton.zap | Matter device configuration defining clusters and endpoints for network infrastructure manager |
| barton-matter_1.4.0.bbappend | BitBake recipe configuring Matter application with ZAP file and persistent storage |
| iptables_nf.cfg | Kernel configuration additions for Bluetooth, USB, TUN, and IEEE 802.15.4 support |
| linux-firmware_%.bbappend | Firmware package recipe limiting to Broadcom and Realtek Bluetooth firmware only |
| packagegroup-rdk-ccsp-broadband.bbappend | Adds Bluetooth firmware packages to runtime dependencies |
| rdk-generic-broadband-image.bbappend | Adds Matter-related services (cpcd, otbr-agent, bluetoothd, barton) to image |
| ExampleTestDACProvider.cpp | Custom Matter Device Attestation Credentials provider implementation |
| barton_%.bbappend | Enables Matter, Thread, and Reference builds with custom providers and delegates |
| otbr-agent_4.4.4.0.bbappend | Extends OTBR D-Bus API with custom patches and installs additional headers |
| otbr-agent_4.4.4.0.bb | Complete OTBR agent recipe with SiliconLabs Gecko SDK integration |
| otbr-agent.service/path | Systemd service files for OTBR agent triggered by cpcd availability |
| openthread-fix-build-errors.patch | Fixes namespace and time constant compatibility in OpenThread platform code |
| adjust-otbr-configuration.patch | Updates Thread version conditionals from exact to minimum version matching |
| 0003-Extend-d-bus-properties-and-signals.patch | Extends OTBR D-Bus interface with BorderAgentId, ThreadNetIfUp properties and signals |
| cpcd files | CPCD service and configuration for co-processor communication over UART |
| bt-host-cpc-hci-bridge files | Bluetooth HCI bridge service connecting CPC to BlueZ stack |
| bluez5_5.%.bbappend | Adds btattach tool installation to BlueZ package |
| utopia.bbappend | Adds FEATURE_MATTER_ENABLED compile flag when matter distro feature is enabled |
| rdk-bpi.inc | Enables 'matter' distribution feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ${@bb.utils.contains('DISTRO_FEATURES', 'OneWifi', 'rdk-wifi-hal', '' ,d)} \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'CPUPROCANALYZER_BROADBAND', 'cpuprocanalyzer', ' ', d)} \ | ||
| linux-firmware-bcm-bt \ | ||
| linux-firmware-rtl-bt \ |
There was a problem hiding this comment.
Trailing whitespace after backslash on line 11. Remove the space after the backslash.
| linux-firmware-rtl-bt \ | |
| linux-firmware-rtl-bt \ |
| @@ -0,0 +1,70 @@ | |||
| From: RDKM | |||
| Date: Wed, 29 Oct 2025 | |||
There was a problem hiding this comment.
Corrected date 'Wed, 29 Oct 2025' should be 'Tue, 29 Oct 2024' as October 29, 2025 falls on a Wednesday but this appears to be a typo for a past date (2024).
| Date: Wed, 29 Oct 2025 | |
| Date: Tue, 29 Oct 2024 |
| @@ -0,0 +1,58 @@ | |||
| From: RDKM | |||
| Date: Wed, 29 Oct 2025 | |||
There was a problem hiding this comment.
Corrected date 'Wed, 29 Oct 2025' should be 'Tue, 29 Oct 2024' as this appears to be a typo for a past date.
| Date: Wed, 29 Oct 2025 | |
| Date: Tue, 29 Oct 2024 |
| CXXFLAGS += "-fPIC" | ||
| CFLAGS += "-fPIC" |
There was a problem hiding this comment.
Direct modification of CFLAGS/CXXFLAGS using += can cause issues in BitBake. Use the _append operator instead: CXXFLAGS_append = \" -fPIC\" and CFLAGS_append = \" -fPIC\" to ensure proper flag concatenation.
| CXXFLAGS += "-fPIC" | |
| CFLAGS += "-fPIC" | |
| CXXFLAGS_append = " -fPIC" | |
| CFLAGS_append = " -fPIC" |
| @@ -0,0 +1,28 @@ | |||
| # TODO: Verify license -- it is Silabs specific | |||
There was a problem hiding this comment.
TODO comment indicates license verification is incomplete. This should be resolved before merging to production, especially for a proprietary license.
| # TODO: Verify license -- it is Silabs specific |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/d9f9c459c08447bb410e4522da40fc77 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/eee05de434d894d3d796f53b7c902272 |
Reason for change: IoT stack for RDK-B
Test Procedure: configure wifi and test with thread and wifi devices
Risks: Low
Signed-off-by: Chandrakanth Pokuru <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 24 out of 26 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,70 @@ | |||
| From: RDKM | |||
| Date: Wed, 29 Oct 2025 | |||
There was a problem hiding this comment.
The date 'Wed, 29 Oct 2025' is in the future and incorrect. October 29, 2025 is a Wednesday, but this appears to be authored in 2024 or earlier. Update to the correct historical date when this patch was created.
| Date: Wed, 29 Oct 2025 | |
| Date: Wed, 29 May 2024 |
| ${@bb.utils.contains('DISTRO_FEATURES', 'OneWifi', 'rdk-wifi-hal', '' ,d)} \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'CPUPROCANALYZER_BROADBAND', 'cpuprocanalyzer', ' ', d)} \ | ||
| linux-firmware-bcm-bt \ | ||
| linux-firmware-rtl-bt \ |
There was a problem hiding this comment.
Trailing whitespace after backslash on line 11. This can cause build issues or unexpected behavior as the backslash may not properly continue the line. Remove the trailing space.
| linux-firmware-rtl-bt \ | |
| linux-firmware-rtl-bt \ |
NOTICE
Outdated
| Copyright (c) 2023 Project CHIP Authors | ||
| Licensed under the Apache License, Version 2.0 | ||
| See the README.md file under recipes-matter for details. | ||
| The parent ZAP file is included as `recipes-matter/barton-matter-reference/files/barton.zap` |
There was a problem hiding this comment.
The referenced path 'recipes-matter/barton-matter-reference/files/barton.zap' does not match the actual location 'meta-rdk-mtk-bpir4/recipes-matter/barton-matter/files/barton.zap'. Update the path to correctly reflect the file location.
| The parent ZAP file is included as `recipes-matter/barton-matter-reference/files/barton.zap` | |
| The parent ZAP file is included as `meta-rdk-mtk-bpir4/recipes-matter/barton-matter/files/barton.zap` |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/c8cb5527a9054252cedc76b59b8b6b71 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/4f555b99061284dc99990e054fa67873 |
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 24 out of 26 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,28 @@ | |||
| # TODO: Verify license -- it is Silabs specific | |||
There was a problem hiding this comment.
The TODO comment in line 1 indicates the license needs verification for Silabs, but the LICENSE field is set to 'Proprietary'. This should be clarified - either remove the TODO if the license is correct, or keep investigating if it's truly proprietary vs. a specific Silabs license.
| # TODO: Verify license -- it is Silabs specific |
| @@ -0,0 +1,67 @@ | |||
| DESCRIPTION = "Bluetooth CPC HCI Bridge" | |||
| LICENSE = "Proprietary" | |||
There was a problem hiding this comment.
The LICENSE is set to 'Proprietary' but the checksum points to a specific license file. If the Gecko SDK has a specific license type (e.g., Zlib as is common for Silabs SDK), the LICENSE field should reflect that rather than 'Proprietary'.
| LICENSE = "Proprietary" | |
| LICENSE = "Zlib" |
| ${@bb.utils.contains('DISTRO_FEATURES', 'OneWifi', 'rdk-wifi-hal', '' ,d)} \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'CPUPROCANALYZER_BROADBAND', 'cpuprocanalyzer', ' ', d)} \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'OneWifi', 'rdk-wifi-hal', '' ,d)} \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'CPUPROCANALYZER_BROADBAND', 'cpuprocanalyzer', ' ', d)} \ |
There was a problem hiding this comment.
Inconsistent whitespace usage before closing parameter: line 8 uses empty string '' while line 9 uses single space ' '. For consistency and clarity, both should use the same convention (preferably empty string).
| ${@bb.utils.contains('DISTRO_FEATURES', 'CPUPROCANALYZER_BROADBAND', 'cpuprocanalyzer', ' ', d)} \ | |
| ${@bb.utils.contains('DISTRO_FEATURES', 'CPUPROCANALYZER_BROADBAND', 'cpuprocanalyzer', '' , d)} \ |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/cc73b10a36141892acd9ed4eb1609457 |
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/60c0f1ba75956262cbc1b6356c844e84 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/3410240cf614ba4726d4de302de09b2e |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/eba45a2bb4bac4363a44a77623e2b843 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/cdcf429b9be0eb798a6995265545a183 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/a81e1f1c33033f34ddeff926fafd724f |
Removed the do_check_matter_configuration function and exported variables for configuration files.
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/151f67330ccaa90189cf3d68cb3e6bf5 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/f81121704fb4bf051c6b97016ddcec26 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/a3e6063767cc95347e4a859e6f6cf703 |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/4b1cc7df5dc5cd6df201ae7434a8634b |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/3865bfde432fb90249e0f19b3e8da6ba |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/259478b19bed45367218b83f4fb7a7af |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/311fcd570dc5e9789fed7a84c7d1f5cf |
|
build-bpi-r4-broadband Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/d19388eb1e1cd3e41d9f8c8360e0c6a5 |
