Conversation
Tag 5.1.0 release
…el 6.12.38 Reason for change: 1. Added the amazon user to video group to get the required DMA heap dev node access Test Procedure: build and amazon playback verified Risks: None. Signed-off-by: [email protected]
RDKEAPPRT-575 To update package.revision and residentui
There was a problem hiding this comment.
Pull request overview
Updates the meta-application layer for the 6.0.0 release, refreshing pinned component revisions and aligning build/config templates and images with the new release requirements.
Changes:
- Bump application-layer packagegroup PV to 6.0.0 and update
CHANGELOG.mdwith a 6.0.0 entry. - Update resident UI/app pinned PV/SRCREV and refresh the
residentuirelease tarball checksum. - Adjust build/config behavior (APP layer arch composition, bblayers template) and extend the amazon non-root user setup in the test image.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-application-layer.bb | Bumps packagegroup PV to 6.0.0. |
| recipes-core/images/application-test-image.bb | Adds amazon user to the video group when amazon_non_root_support is enabled. |
| recipes-apps/residentui/residentui.bb | Updates the residentui release tarball sha256 to match the pinned PV. |
| conf/template/bblayers.conf.sample | Removes optional OSS release layer path from the sample bblayers template. |
| conf/machine/include/package_revisions.inc | Updates pinned PV/SRCREV for rdkresidentapp and residentui. |
| conf/machine/include/application.inc | Introduces an extension variable and uses it to compose APP_LAYER_ARCH. |
| CHANGELOG.md | Adds a 6.0.0 section and amends the 5.1.0 section formatting/content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -14,6 +14,7 @@ inherit core-image custom-rootfs-creation extrausers | |||
| EXTRA_USERS_PARAMS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'amazon_non_root_support', '''\ | |||
| groupadd -g 1001 amazon;\ | |||
| useradd -u 1001 -g amazon -M -r -s /bin/sh amazon;\ | |||
There was a problem hiding this comment.
usermod -a -G video amazon assumes a video group exists at image creation time, but this snippet doesn't create it. If the base image doesn't provide that group, the rootfs build will fail. Consider ensuring the group exists (e.g., add a conditional groupadd for video before the usermod, or otherwise guarantee it's present via installed packages).
| useradd -u 1001 -g amazon -M -r -s /bin/sh amazon;\ | |
| useradd -u 1001 -g amazon -M -r -s /bin/sh amazon;\ | |
| groupadd -f video;\ |
| #### [6.0.0](https://github.com/rdkcentral/meta-application-rdke-dev/compare/5.1.0...6.0.0) | ||
|
|
||
| - RDKEAPPRT-575 To update package.revision and residentui [`#169`](https://github.com/rdkcentral/meta-application-rdke-dev/pull/169) | ||
| - RDKEVL-7365:[RPI] OSS and common metalayers update [`b9db7a1`](https://github.com/rdkcentral/meta-application-rdke-dev/commit/b9db7a17ff9359498fb7cf47ee34ad0b9b0553a9) | ||
| - RTK-1961 Amazon Prime app displays a black screen on launch with Kernel 6.12.38 [`db99abc`](https://github.com/rdkcentral/meta-application-rdke-dev/commit/db99abc7978ccafa9053034b352416faa5ea6beb) | ||
| - Merge tag '5.1.0' into develop [`462439a`](https://github.com/rdkcentral/meta-application-rdke-dev/commit/462439af00baa6f4c4501628fbc1040da946a6c1) | ||
|
|
There was a problem hiding this comment.
The changelog entries in this file typically include a release date line (e.g., > 22 December 2025 for 5.1.0), but the new 6.0.0 section doesn't. Add the 6.0.0 release date to keep the format consistent.
| LAYER_EXTENSION = "-application" | ||
|
|
||
| APP_LAYER_ARCH ??= "${MACHINE}${LAYER_EXTENSION}" |
There was a problem hiding this comment.
LAYER_EXTENSION is introduced as a very generic variable name and is set with a hard assignment (=). To avoid accidental collisions with other layers/configs and to make overrides easier, consider renaming it to something application-layer-specific (e.g., APP_LAYER_EXTENSION) and using a weak/default assignment (?= or ??=) if overrides are expected.
| LAYER_EXTENSION = "-application" | |
| APP_LAYER_ARCH ??= "${MACHINE}${LAYER_EXTENSION}" | |
| APP_LAYER_EXTENSION ??= "-application" | |
| APP_LAYER_ARCH ??= "${MACHINE}${APP_LAYER_EXTENSION}" |
4 participants
No description provided.