Skip to content

RDKB-62810,RDKB-62812:Create Virtual Interface for voice and initialize DHCP #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snayak002c merged 19 commits into from
Feb 16, 2026
Merged

RDKB-62810,RDKB-62812:Create Virtual Interface for voice and initialize DHCP #25

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
89aaf6b
RDKB-777777: Get the udhcpc arguments for virtual mta interface
Amaresh-Kotekal Nov 27, 2025
48d8563
RDKB-777777: Get the udhcpc arguments for macvlan mta interface
Amaresh-Kotekal Dec 12, 2025
0bee820
RDKB-777777: Get the udhcpc arguments for macvlan mta interface
Dec 20, 2025
e923264
RDKB-777777: Get the udhcpc arguments for macvlan mta interface
Amaresh-Kotekal Dec 23, 2025
dedfdf0
RDKB-777777: Get the udhcpc arguments for macvlan mta interface
Amaresh-Kotekal Dec 24, 2025
05bedb4
RDKB-62812:Create Virtual Interface for voice and initialize DHCP
Amaresh-Kotekal Dec 25, 2025
e0dd077
RDKB-62812:Create Virtual Interface for voice and initialize DHCP
Amaresh-Kotekal Jan 7, 2026
afd0465
RDKB-62812:Create Virtual Interface for voice and initialize DHCP
Amaresh-Kotekal Jan 13, 2026
ba58939
RDKB-62812:Create Virtual Interface for voice and initialize DHCP
Amaresh-Kotekal Jan 14, 2026
e92cc75
RDKB-62812:Create Virtual Interface for voice and initialize DHCP
Amaresh-Kotekal Jan 16, 2026
bf25df6
RDKB-62812:Create Virtual Interface for voice and initialize DHCP
Amaresh-Kotekal Jan 21, 2026
b9ceec9
RDKB-62812:Create Virtual Interface for voice and initialize DHCP
Amaresh-Kotekal Jan 28, 2026
bc3f341
RDKB-62813:DHCP Data Handling and Initialization of voice
Amaresh-Kotekal Jan 31, 2026
b290099
RDKB-62813:DHCP Data Handling and Initialization of voice
Amaresh-Kotekal Feb 4, 2026
8f9b15d
RDKB-62813:DHCP Data Handling and Initialization of voice
Amaresh-Kotekal Feb 6, 2026
a918674
RDKB-62813:DHCP Data Handling and Initialization of voice
Amaresh-Kotekal Feb 6, 2026
322656a
RDKB-62813:DHCP Data Handling and Initialization of voice
Amaresh-Kotekal Feb 7, 2026
97c65e6
RDKB-62813:DHCP Data Handling and Initialization of voice
Amaresh-Kotekal Feb 13, 2026
a88bf6e
RDKB-62813:DHCP Data Handling and Initialization of voice
Amaresh-Kotekal Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions config/CcspMtaAgent.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2639,6 +2639,97 @@
</parameters>
</object>

<?ifdef FEATURE_SUPPORT_VOICE_MTA?>
<object><name>Services</name><objectType>object</objectType>
<objects><object><name>BrcmVoiceService</name><objectType>object</objectType>

<functions>
<func_SetParamStringValue>BrcmVoiceService_NotifyIfIp_SetParamStringValue</func_SetParamStringValue>
</functions>

<parameters>
<parameter>
<name>X_BROADCOM_COM_NotifyIfIp</name>
<type>string(128)</type><syntax>string</syntax><writable>true</writable>
</parameter>
</parameters>

<objects><object><name>1</name><objectType>object</objectType>

<functions>
<func_GetParamStringValue>BrcmVoiceService_GetParamStringValue</func_GetParamStringValue>
<func_SetParamStringValue>BrcmVoiceService_SetParamStringValue</func_SetParamStringValue>
</functions>

<parameters>
<parameter>
<name>X_BROADCOM_COM_BoundIfName</name>
<type>string(32)</type><syntax>string</syntax><writable>true</writable>
</parameter>
<parameter>
<name>X_BROADCOM_COM_ModuleLogLevels</name>
<type>string(128)</type><syntax>string</syntax><writable>true</writable>
</parameter>
</parameters>

<objects><object><name>SIP</name><objectType>object</objectType>

<objects>
<object><name>Network</name><objectType>object</objectType>
<objects><object><name>1</name><objectType>object</objectType>

<functions>
<func_GetParamStringValue>BrcmVoiceNetwork_GetParamStringValue</func_GetParamStringValue>
<func_SetParamStringValue>BrcmVoiceNetwork_SetParamStringValue</func_SetParamStringValue>
</functions>

<parameters>
<parameter>
<name>ProxyServer</name>
<type>string(128)</type><syntax>string</syntax><writable>true</writable>
</parameter>
<parameter>
<name>RegistrarServer</name>
<type>string(128)</type><syntax>string</syntax><writable>true</writable>
</parameter>
</parameters>

</object></objects>
</object>

<object><name>Client</name><objectType>object</objectType>
<objects><object><name>1</name><objectType>object</objectType>

<functions>
<func_GetParamStringValue>BrcmVoiceClient_GetParamStringValue</func_GetParamStringValue>
<func_SetParamStringValue>BrcmVoiceClient_SetParamStringValue</func_SetParamStringValue>
</functions>

<parameters>
<parameter>
<name>RegisterURI</name>
<type>string(128)</type><syntax>string</syntax><writable>true</writable>
</parameter>
<parameter>
<name>AuthUserName</name>
<type>string(128)</type><syntax>string</syntax><writable>true</writable>
</parameter>
<parameter>
<name>AuthPassword</name>
<type>string(128)</type><syntax>string</syntax><writable>true</writable>
</parameter>
</parameters>

</object></objects>
</object>
</objects>

</object></objects>
</object></objects>
</object></objects>
</object>
<?endif?>
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML configuration introduces new data model objects under Services.BrcmVoiceService with various string parameters. However, there's no input validation specified in the XML or visible in the corresponding DML functions (BrcmVoiceService_SetParamStringValue, BrcmVoiceNetwork_SetParamStringValue, BrcmVoiceClient_SetParamStringValue) that validates the input before passing it to bcm_generic_setParameterValues. Consider adding length checks and format validation for parameters like RegisterURI, ProxyServer, RegistrarServer, etc., to prevent injection attacks or malformed data from being stored.

Copilot uses AI. Check for mistakes.

</objects>

</dataModelInfo>
10 changes: 10 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ AC_ARG_ENABLE([unitTestDockerSupport],
[echo "Docker support is disabled"])
AM_CONDITIONAL([UNIT_TEST_DOCKER_SUPPORT], [test x$UNIT_TEST_DOCKER_SUPPORT = xtrue])

# Checks for Voice_support
AC_ARG_ENABLE([voice_support],
[ --enable-voice_support=val Turn on voice support, val=true or false],
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configure.ac help text on line 46 has inconsistent formatting. It says "Turn on voice support, val=true or false" but the valid values for --enable-voice_support are "yes" and "no" (as shown in the case statement on lines 48-49), not "true" or "false". Update the help text to accurately reflect the valid values: "Turn on voice support (yes/no)"

Suggested change
[ --enable-voice_support=val Turn on voice support, val=true or false],
[ --enable-voice_support=val Turn on voice support (yes/no)],

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --enable-voice_support help text says val=true or false, but the case only accepts yes/no and will error on true/false. Either update the help string to yes|no or accept true|false as valid values.

Suggested change
[ --enable-voice_support=val Turn on voice support, val=true or false],
[ --enable-voice_support=val Turn on voice support, val=yes or no],

Copilot uses AI. Check for mistakes.
[case "${enableval}" in
yes) voice_support=true ;;
no) voice_support=false ;;
*) AC_MSG_ERROR([bad value ${enableval} for --enable-voice_support]) ;;
esac],[voice_support=false])
AM_CONDITIONAL(VOICE_SUPPORT_ENABLED, test x"$voice_support" = x"true")
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configure.ac defines AM_CONDITIONAL for VOICE_SUPPORT_ENABLED but the Makefile.am checks for VOICE_MTA_SUPPORT. This inconsistency could lead to build configuration issues. Ensure these conditional names match or document why they differ.

Suggested change
AM_CONDITIONAL(VOICE_SUPPORT_ENABLED, test x"$voice_support" = x"true")
AM_CONDITIONAL(VOICE_SUPPORT_ENABLED, test x"$voice_support" = x"true")
AM_CONDITIONAL(VOICE_MTA_SUPPORT, test x"$voice_support" = x"true")

Copilot uses AI. Check for mistakes.

AC_PREFIX_DEFAULT(`pwd`)
AC_ENABLE_SHARED
AC_DISABLE_STATIC
Expand Down
4 changes: 4 additions & 0 deletions source/TR-181/include/cosa_x_cisco_com_mta_apis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@ typedef enum
/**********************************************************************
FUNCTION PROTOTYPES
**********************************************************************/
#if defined (SCXF10)
void
CosaDmlNotifyIf(char *pIpAddr);
#endif

ANSC_STATUS
CosaDmlMTAInit
Expand Down
Loading