Conversation
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
…nto feature/RDKEMW-1017_1018_miracast_comrpc_support
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
…ssue Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
…ents API Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
| m_video_sink_rect = {0, 0, 1920, 1080}; // Default video rectangle | ||
| m_GstPlayer = nullptr; | ||
| MIRACAST::logger_init("MiracastPlayer"); | ||
| } |
There was a problem hiding this comment.
Coverity Issue - Uninitialized pointer field
Non-static class member "_service" is not initialized in this constructor nor in any functions that it calls.
Medium Impact, CWE-457
UNINIT_CTOR
| } | ||
| else | ||
| { | ||
| setEnableInternal(false); |
There was a problem hiding this comment.
Coverity Issue - Waiting while holding a lock
Call to "setEnableInternal" might sleep while holding lock "lck._M_device".
Medium Impact, CWE-667
SLEEP
| } | ||
| else | ||
| { | ||
| setEnableInternal(false); |
There was a problem hiding this comment.
Coverity Issue - Waiting while holding a lock
Call to "setEnableInternal" might sleep while holding lock "lock._M_device".
Medium Impact, CWE-667
SLEEP
| { | ||
| MIRACASTLOG_INFO("#### MCAST-TRIAGE-OK-WIFI DEVICE_WIFI_STATE [CONNECTING] ####"); | ||
| {lock_guard<recursive_mutex> lock(m_EventMutex); | ||
| setEnableInternal(false); |
There was a problem hiding this comment.
Coverity Issue - Waiting while holding a lock
Call to "setEnableInternal" might sleep while holding lock "lck._M_device".
Medium Impact, CWE-667
SLEEP
| { | ||
| MIRACASTLOG_INFO("#### MCAST-TRIAGE-OK-WIFI DEVICE_WIFI_STATE [CONNECTING] ####"); | ||
| {lock_guard<recursive_mutex> lock(m_EventMutex); | ||
| setEnableInternal(false); |
There was a problem hiding this comment.
Coverity Issue - Waiting while holding a lock
Call to "setEnableInternal" might sleep while holding lock "lock._M_device".
Medium Impact, CWE-667
SLEEP
| return; | ||
| } | ||
| lock_guard<mutex> lck(_instance->m_DiscoveryStateMutex); | ||
| _instance->setPowerStateInternal(newState); |
There was a problem hiding this comment.
Coverity Issue - Waiting while holding a lock
Call to "setPowerStateInternal" might sleep while holding lock "lck._M_device".
Medium Impact, CWE-667
SLEEP
| if ( _instance->m_isServiceEnabled ) | ||
| { | ||
| MIRACASTLOG_INFO("#### MCAST-TRIAGE-OK-PWR Miracast Discovery Disabled ####"); | ||
| _instance->setEnableInternal(false); |
There was a problem hiding this comment.
Coverity Issue - Waiting while holding a lock
Call to "setEnableInternal" might sleep while holding lock "lock._M_device".
Medium Impact, CWE-667
SLEEP
| } | ||
|
|
||
| public: | ||
| static Core::ProxyType<Core::IDispatch> Create(MiracastServiceImplementation *miracastServiceImplementation, Event event, ParamsType params) |
There was a problem hiding this comment.
Coverity Issue - Big parameter passed by value
Passing parameter params of type "ParamsType" (size 136 bytes) by value, which exceeds the low threshold of 128 bytes.
Low Impact, CWE-398
PASS_BY_VALUE
2 participants
No description provided.