Skip to content

Topic/rdkemw 3705 testcoverity #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agampa263 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Topic/rdkemw 3705 testcoverity #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1a630
RDKEMW-3705: Fix Coverity identified issues in ENTServices-Casting Repo
agampa263 May 27, 2025
b4819d9
Update CMakeLists.txt
agampa263 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ if(ENABLE_COMMUNITY_DEVICE_TYPE)
add_definitions(-DENABLE_COMMUNITY_DEVICE_TYPE)
endif()

if(RDK_SERVICES_L1_TEST)
add_subdirectory(Tests/L1Tests)
endif()

if(PLUGIN_XCAST)
add_subdirectory(XCast)
endif()
Expand Down
4 changes: 2 additions & 2 deletions Miracast/common/MiracastLogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ namespace MIRACAST
setvbuf(stdout, NULL, _IOLBF, 0);
}

const char *methodName(const std::string &prettyFunction)
std::string methodName(const std::string &prettyFunction)
{
size_t colons = prettyFunction.find("::");
size_t begin = prettyFunction.substr(0, colons).rfind(" ") + 1;
size_t end = prettyFunction.rfind("(") - begin;

return prettyFunction.substr(begin, end).c_str();
return prettyFunction.substr(begin, end);
}

static int gDefaultLogLevel = INFO_LEVEL;
Expand Down
2 changes: 1 addition & 1 deletion Miracast/common/MiracastLogger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* If not stated otherwise in this file or this component's Licenses.txt file the
* following copyright and licenses apply:

Check failure on line 3 in Miracast/common/MiracastLogger.h

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'Miracast/common/MiracastLogger.h' (Match: rdkcentral/rdkservices/1, 90 lines, url: https://github.com/rdkcentral/rdkservices/archive/GRT_v1.tar.gz, file: TextToSpeech/impl/logger.h)
*
* Copyright 2023 RDK Management
*
Expand Down Expand Up @@ -31,7 +31,7 @@

namespace MIRACAST {

const char* methodName(const std::string& prettyFunction);
std::string methodName(const std::string& prettyFunction);
#define __METHOD_NAME__ MIRACAST::methodName(__PRETTY_FUNCTION__)

/**
Expand Down
2 changes: 1 addition & 1 deletion XCast/XCast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/**

Check failure on line 1 in XCast/XCast.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'XCast/XCast.cpp' (Match: rdkcentral/rdkservices/1, 1368 lines, url: https://github.com/rdkcentral/rdkservices/archive/GRT_v1.tar.gz, file: XCast/XCast.cpp)
* If not stated otherwise in this file or this component's LICENSE
* file the following copyright and licenses apply:
*
Expand Down Expand Up @@ -1022,7 +1022,7 @@
itrName = jNames[i].String().c_str();
LOGINFO("%s, size:%d", itrName.c_str(), (int)strlen (itrName.c_str()));
DynamicAppConfig* pDynamicAppConfig = (DynamicAppConfig*) malloc (sizeof(DynamicAppConfig));
memset ((void*)pDynamicAppConfig, '0', sizeof(DynamicAppConfig));
memset ((void*)pDynamicAppConfig, '\0', sizeof(DynamicAppConfig));
memset (pDynamicAppConfig->appName, '\0', sizeof(pDynamicAppConfig->appName));
strncpy (pDynamicAppConfig->appName, itrName.c_str(), sizeof(pDynamicAppConfig->appName) - 1);
pDynamicAppConfig->appName[sizeof(pDynamicAppConfig->appName) - 1] = '\0';
Expand Down
2 changes: 1 addition & 1 deletion XCast/XCastImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ namespace Plugin {
DynamicAppConfig* pDynamicAppConfig = (DynamicAppConfig*) malloc (sizeof(DynamicAppConfig));
if (pDynamicAppConfig)
{
memset ((void*)pDynamicAppConfig, '0', sizeof(DynamicAppConfig));
memset ((void*)pDynamicAppConfig, '\0', sizeof(DynamicAppConfig));
memset (pDynamicAppConfig->appName, '\0', sizeof(pDynamicAppConfig->appName));
memset (pDynamicAppConfig->prefixes, '\0', sizeof(pDynamicAppConfig->prefixes));
memset (pDynamicAppConfig->cors, '\0', sizeof(pDynamicAppConfig->cors));
Expand Down
Loading