Skip to content

fix: uninitialized variable usage fixed #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nnaveen979 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: uninitialized variable usage fixed #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2918291
fix: uninitialized variable usage fixed
Nov 17, 2025
e0e762a
Merge remote-tracking branch 'origin/main' into uninit
Nov 18, 2025
8d6f748
Merge branch 'develop' into uninit
Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Miracast/MiracastService/MiracastController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* If not stated otherwise in this file or this component's Licenses.txt file the

Check failure on line 2 in Miracast/MiracastService/MiracastController.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'Miracast/MiracastService/MiracastController.cpp' (Match: rdkcentral/rdkservices/6.1.7, 1610 lines, url: https://github.com/rdkcentral/rdkservices/archive/refs/tags/AML_BSP_REL_VERSION_RDK6.1.7.tar.gz, file: Miracast/MiracastService/MiracastController.cpp)
* following copyright and licenses apply:
*
* Copyright 2023 RDK Management
Expand Down Expand Up @@ -952,7 +952,7 @@
authType = "pbc",
deviceType = "unknown",
result = "";
m_groupInfo = new GroupInfo;
m_groupInfo = new GroupInfo();
size_t found = event_buffer.find("client");
size_t found_space = event_buffer.find(" ");

Expand Down Expand Up @@ -1004,7 +1004,6 @@
std::string default_gw_ip = "";

// STB is a client in the p2p group
m_groupInfo->isGO = false;
m_groupInfo->localIPAddr = start_DHCPClient(m_groupInfo->interface, default_gw_ip);
if (m_groupInfo->localIPAddr.empty())
{
Expand Down
12 changes: 12 additions & 0 deletions Miracast/common/MiracastCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* If not stated otherwise in this file or this component's Licenses.txt file the

Check failure on line 2 in Miracast/common/MiracastCommon.h

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'Miracast/common/MiracastCommon.h' (Match: rdkcentral/rdkservices/6.1.7, 244 lines, url: https://github.com/rdkcentral/rdkservices/archive/refs/tags/AML_BSP_REL_VERSION_RDK6.1.7.tar.gz, file: Miracast/common/MiracastCommon.h)
* following copyright and licenses apply:
*
* Copyright 2023 RDK Management
Expand Down Expand Up @@ -125,6 +125,18 @@
std::string ipMask;
std::string srcDevIPAddr;
std::string localIPAddr;

// Constructor to ensure proper initialization
group_info()
: interface("")
, isGO(false)
, SSID("")
, goDevAddr("")
, ipAddr("")
, ipMask("")
, srcDevIPAddr("")
, localIPAddr("")
{}
} GroupInfo;

typedef enum msg_type_e
Expand Down
Loading