Test malloc by preeja33 · Pull Request #119 · rdkcentral/entservices-casting

preeja33 · 2025-08-20T13:09:47Z

No description provided.

CLAassistant · 2025-08-20T13:09:57Z

All committers have signed the CLA.

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1528

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1652

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1956

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1428

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1816

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1328

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1222

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:481

rdkcmf-jenkins · 2025-08-20T13:21:52Z

Coverity Issue - Out-of-bounds access

Allocating insufficient memory for the terminating null of the string.

High Impact, CWE-119
OVERRUN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
Tests/L1Tests/tests/test_MiracastService.cpp:1068

rdkcmf-jenkins · 2025-08-21T11:06:02Z

Miracast/MiracastService/MiracastController.cpp

@@ -71,7 +71,7 @@ MiracastController::MiracastController(void)

 MiracastController::~MiracastController()


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Uncaught exception

An exception of type "std::regex_error" is thrown but the exception specification "/implicit/noexcept" doesn't allow it to be thrown. This will result in a call to terminate().

Medium Impact, CWE-248
UNCAUGHT_EXCEPT

rdkcmf-jenkins · 2025-08-21T12:19:59Z

Miracast/common/MiracastCommon.cpp

    if (nullptr != m_g_queue){
+
+
+        MIRACASTLOG_TRACE("Queue size", g_async_queue_length(m_g_queue));


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Extra argument to printf format specifier

This argument was not used by the format string: "g_async_queue_length(this->m_g_queue)".

Low Impact, CWE-685
PRINTF_ARGS

rdkcmf-jenkins · 2025-08-21T16:58:50Z

Miracast/common/MiracastCommon.cpp

+
+
+    // Allocate wrapper and push to queue
+    auto* wrapper = new std::shared_ptr<std::vector<char>>(buffer);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"buffer" is passed-by-value as parameter to "std::shared_ptr<std::vector<char, std::allocator > >::shared_ptr(std::shared_ptr<std::vector<char, std::allocator > > const &) /explicit =default/", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""buffer"")" instead of "buffer".

rdkcmf-jenkins · 2025-08-28T14:05:32Z

Miracast/MiracastService/MiracastServiceImplementation.cpp

+                m_CurrentService = nullptr;
+                m_miracast_ctrler_obj = nullptr;
+                m_isServiceInitialized = false;
+                m_isServiceEnabled = false;


Coverity Issue - Data race condition

Accessing "this->m_isServiceEnabled" without holding lock "WPEFramework::Plugin::MiracastServiceImplementation.m_EventMutex". Elsewhere, "WPEFramework::Plugin::MiracastServiceImplementation.m_isServiceEnabled" is written to with "MiracastServiceImplementation.m_EventMutex" held 2 out of 2 times (2 of these accesses strongly imply that it is necessary).

Medium Impact, CWE-366
MISSING_LOCK

rdkcmf-jenkins · 2025-08-28T14:05:33Z

Miracast/MiracastService/MiracastService.cpp

                /* Make sure the Activated and Deactivated are no longer called before we start cleaning up.. */
-                mCurrentService->Unregister(&mMiracastServiceNotification);
+                   mCurrentService->Unregister(&mMiracastServiceNotification);
+                   mConfigure = mMiracastServiceImpl->QueryInterface<Exchange::IConfiguration>();


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference after null check

Passing null pointer "this->mMiracastServiceImpl" to "QueryInterface", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

rdkcmf-jenkins · 2025-08-28T14:05:34Z

Miracast/MiracastService/MiracastService.cpp

                /* Make sure the Activated and Deactivated are no longer called before we start cleaning up.. */
-                mCurrentService->Unregister(&mMiracastServiceNotification);
+                   mCurrentService->Unregister(&mMiracastServiceNotification);
+                   mConfigure = mMiracastServiceImpl->QueryInterface<Exchange::IConfiguration>();


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Explicit null dereferenced

Passing null pointer "this->mMiracastServiceImpl" to "QueryInterface", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

rdkcmf-jenkins · 2025-08-28T14:46:13Z

Miracast/MiracastService/MiracastService.cpp

-                mCurrentService = nullptr;
-            }
+                   mCurrentService->Unregister(&mMiracastServiceNotification);
+                   Exchange::IConfiguration* mConfigure1 = mMiracastServiceImpl->QueryInterface<Exchange::IConfiguration>();


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference after null check

Passing null pointer "this->mMiracastServiceImpl" to "QueryInterface", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

rdkcmf-jenkins · 2025-08-28T14:46:13Z

Miracast/MiracastService/MiracastService.cpp

-                mCurrentService = nullptr;
-            }
+                   mCurrentService->Unregister(&mMiracastServiceNotification);
+                   Exchange::IConfiguration* mConfigure1 = mMiracastServiceImpl->QueryInterface<Exchange::IConfiguration>();


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Explicit null dereferenced

Passing null pointer "this->mMiracastServiceImpl" to "QueryInterface", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

preeja33 added 3 commits August 20, 2025 18:20

add sleep in destructor of test

90031b5

Update MiracastServiceImplementation.cpp

0c277fd

Update L1-tests.yml

c361e04

preeja33 requested a review from a team as a code owner August 20, 2025 13:09

preeja33 added 10 commits August 20, 2025 21:09

Update MiracastController.cpp

ed8950a

Update MiracastController.cpp

6d1817d

Update MiracastController.cpp

d7c93e9

Update MiracastP2P.cpp

b960740

Update MiracastController.cpp

256de6d

Update MiracastP2P.cpp

b6616ae

Update MiracastCommon.cpp

18377be

Update MiracastLogger.cpp

97bf9d1

Update MiracastP2P.cpp

5b72bc0

Update MiracastController.cpp

4834db8

rdkcmf-jenkins reviewed Aug 21, 2025

View reviewed changes

preeja33 added 4 commits August 21, 2025 16:48

Update MiracastController.cpp

c431142

Update MiracastCommon.cpp

2cfd0c0

Update MiracastController.cpp

e4b52b9

Update MiracastCommon.cpp

d07c743

rdkcmf-jenkins reviewed Aug 21, 2025

View reviewed changes

Update MiracastCommon.cpp

b4fa0eb

rdkcmf-jenkins reviewed Aug 21, 2025

View reviewed changes

preeja33 added 17 commits August 22, 2025 08:12

Update MiracastCommon.cpp

1a0e2bf

Update MiracastCommon.cpp

7979434

Update MiracastController.cpp

a2fa25c

Update MiracastServiceImplementation.cpp

fa8e4bf

Update test_MiracastService.cpp

07cb92a

Update test_MiracastService.cpp

c5339da

Update test_MiracastService.cpp

85ccdca

Update test_MiracastService.cpp

e83e97f

Update MiracastServiceImplementation.cpp

93329d9

remove sleep hack

873d70d

comment plyaer test

85d314d

Update test_MiracastPlayer.cpp

a07917b

Update MiracastService.cpp

f2b9040

Update MiracastServiceImplementation.cpp

8f933c6

Update MiracastServiceImplementation.cpp

c908a60

Update MiracastService.cpp

829410b

Update MiracastService.cpp

09fe767

rdkcmf-jenkins reviewed Aug 28, 2025

View reviewed changes

preeja33 added 2 commits August 28, 2025 20:00

Update MiracastService.cpp

682f835

Update MiracastService.cpp

5286bc1

rdkcmf-jenkins reviewed Aug 28, 2025

View reviewed changes

preeja33 and others added 7 commits August 28, 2025 20:28

Update MiracastService.cpp

43653bb

Update MiracastController.cpp

e379875

Update MiracastService.cpp

11728ad

Update test_MiracastService.cpp

70c35a2

Update MiracastServiceImplementation.cpp

f18129e

Update MiracastService.cpp

fae9ae2

Merge branch 'develop' into test_malloc

ce3b0ee

		@@ -71,7 +71,7 @@ MiracastController::MiracastController(void)

		MiracastController::~MiracastController()

		if (nullptr != m_g_queue){


		MIRACASTLOG_TRACE("Queue size", g_async_queue_length(m_g_queue));



		// Allocate wrapper and push to queue
		auto* wrapper = new std::shared_ptr<std::vector<char>>(buffer);

Conversation

preeja33 commented Aug 20, 2025

Uh oh!

CLAassistant commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Out-of-bounds access

Issue location

Uh oh!

rdkcmf-jenkins Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Uncaught exception

Uh oh!

rdkcmf-jenkins Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Extra argument to printf format specifier

Uh oh!

rdkcmf-jenkins Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Aug 28, 2025

Choose a reason for hiding this comment

Coverity Issue - Data race condition

Uh oh!

rdkcmf-jenkins Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Dereference after null check

Uh oh!

rdkcmf-jenkins Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Explicit null dereferenced

CLAassistant commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins commented Aug 20, 2025 •

edited

Loading

rdkcmf-jenkins Aug 21, 2025 •

edited

Loading

rdkcmf-jenkins Aug 21, 2025 •

edited

Loading

rdkcmf-jenkins Aug 21, 2025 •

edited

Loading

rdkcmf-jenkins Aug 28, 2025 •

edited

Loading

rdkcmf-jenkins Aug 28, 2025 •

edited

Loading

rdkcmf-jenkins Aug 28, 2025 •

edited

Loading

rdkcmf-jenkins Aug 28, 2025 •

edited

Loading