RDKBNETWOR-84: DSLite feature integration with WanManager (Wg network… #50
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11 development) * RDKBNETWOR-85 : DHCP Manager changes for option 64 * pass received endpoint name to wanmanager via rbus publish Signed-off-by: Devin Mungan <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR integrates the DSLite feature with WanManager by renaming the AFTR (Access Gateway for DS-Lite) field to the more generic endpointName throughout the DHCPv6 handling code, and adds support for passing the received endpoint name to WanManager via RBUS publish.
- Refactored AFTR field to
endpointNameacross DHCPv6 structures and processing functions - Added a
trim()utility function to clean whitespace from endpoint names - Updated DHCPv6 lease comparison logic to include endpoint name validation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/TR-181/middle_layer_src/dhcpmgr_rbus_apis.c | Added endpointName field copying to DHCP_MGR_IPV6_MSG structure for RBUS event publishing |
| source/DHCPMgrUtils/dhcpmgr_v6_lease_handler.c | Updated lease comparison function to compare endpointName instead of aftr field |
| source/DHCPClientUtils/DHCPv6Client/dhcpv6_interface.h | Renamed AFTR_NAME_LENGTH to ENDPOINT_NAME_LENGTH and aftr field to endpointName in DHCPv6_PLUGIN_MSG structure |
| source/DHCPClientUtils/DHCPv6Client/dhcpmgr_dibbler_plugin/dhcpmgr_dibbler_plugin.c | Added trim function for string cleanup, updated DHCPv6 option 64 handling to use endpointName with trimming, and updated log messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
source/DHCPClientUtils/DHCPv6Client/dhcpmgr_dibbler_plugin/dhcpmgr_dibbler_plugin.c
Outdated
Show resolved
Hide resolved
sichevoi
reviewed
Jan 5, 2026
source/DHCPClientUtils/DHCPv6Client/dhcpmgr_dibbler_plugin/dhcpmgr_dibbler_plugin.c
Outdated
Show resolved
Hide resolved
hpatel006c
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…11 development)
RDKBNETWOR-85 : DHCP Manager changes for option 64
pass received endpoint name to wanmanager via rbus publish