Feature/rdkemw 8587 dlsym by suppal045 · Pull Request #186 · rdkcentral/devicesettings

suppal045 · 2025-12-11T16:17:19Z

No description provided.

* RDKEMW-4848: pass the proper handle to dsEnableHDCP

Copilot

Pull request overview

This PR refactors the dynamic library loading mechanism for device settings configuration to use a shared library handle instead of opening/closing the library multiple times. The changes introduce a centralized getDLInstance() and releaseDLInstance() pattern, and update all config loading methods to accept a handle parameter.

Key Changes

Centralized dynamic library handle management with thread-safe singleton pattern
Updated all config load methods to accept a void* pDLHandle parameter
Added support for FrontPanelConfig in the initialization flow
Removed the parse_opt_flag() function and associated delay logic

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
ds/manager.cpp	Added getDLInstance/releaseDLInstance functions, refactored searchConfigs to use provided handle, updated Initialize/load methods to pass handle to configs, removed parse_opt_flag function and delay logic
ds/include/manager.hpp	Updated searchConfigs declaration to include pDLHandle parameter, removed parse_opt_flag declaration
ds/videoOutputPortConfig.hpp	Updated load method signature to accept pDLHandle parameter
ds/videoOutputPortConfig.cpp	Refactored load to accept handle parameter, moved symbol search variables into conditional block, added dynamic vs old config loading logic
ds/videoDeviceConfig.hpp	Updated load method signature to accept pDLHandle parameter
ds/videoDeviceConfig.cpp	Refactored load to accept handle parameter, added dynamic vs old config loading logic
ds/audioOutputPortConfig.hpp	Updated load method signature to accept pDLHandle parameter
ds/audioOutputPortConfig.cpp	Refactored load to accept handle parameter, added dynamic vs old config loading logic
ds/include/frontPanelConfig.hpp	Moved load method from private to public, added m_isFPConfigLoaded member, updated load signature to accept pDLHandle
ds/frontPanelConfig.cpp	Removed load call from getInstance, added load validation checks with m_isFPConfigLoaded, refactored load to accept handle parameter and support dynamic/old config loading

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-11T16:21:04Z

ds/frontPanelConfig.cpp

-														  configuration.pKIndicators[i].colorMode));
-				}
-		}
+    if (pDLHandle)


In the FrontPanelConfig::load method, the check for pDLHandle uses a different null comparison pattern (pDLHandle without nullptr comparison) compared to other config files which consistently use "nullptr != pDLHandle". Consider using "nullptr != pDLHandle" for consistency with the rest of the codebase.

Suggested change

if (pDLHandle)

if (nullptr != pDLHandle)

Copilot · 2025-12-11T16:21:04Z

ds/frontPanelConfig.cpp

+    }
+    m_isFPConfigLoaded = true;
 	INT_INFO("Exit function\n");
+    return;


The explicit return statement at the end of a void function is unnecessary. Since this function returns void, the return statement at line 554 can be removed as the function will automatically return at its end.

Suggested change

return;

Copilot · 2025-12-11T16:21:05Z

ds/videoDeviceConfig.cpp

+
+    if ( false == isDynamicConfigLoad)
 	{
 		INT_INFO("Read Old Configs\n");


The log message format for old config loading is inconsistent. In videoDeviceConfig.cpp line 164 it says "Read Old Configs" while other files (videoOutputPortConfig.cpp line 435, audioOutputPortConfig.cpp line 235, frontPanelConfig.cpp line 482) consistently use "Using OLD config loading". Consider updating this message to match the consistent pattern used elsewhere.

Suggested change

INT_INFO("Read Old Configs\n");

INT_INFO("Using OLD config loading\n");

Copilot · 2025-12-11T16:21:05Z

ds/manager.cpp

+void* getDLInstance()
+{
+    std::lock_guard<std::mutex> lock(gDLMutex);
+    dlerror(); // clear old error
+    if (nullptr == gDLHandle){
+        gDLHandle = dlopen(RDK_DSHAL_NAME, RTLD_LAZY);
+    }
+    INT_INFO("%d:%s: DL Instance '%s'\n", __LINE__, __func__, (nullptr == gDLHandle ? "NULL" : "Valid"));
+    return gDLHandle;
+}


The getDLInstance function does not log or handle the error when dlopen fails. The old implementation would log the error message from dlerror(), but this new implementation only logs whether the handle is NULL or Valid. Consider logging the actual error message from dlerror() when dlopen fails to aid in debugging issues with loading the dynamic library.

Copilot · 2025-12-11T16:21:06Z

ds/manager.cpp

+    void* pDLHandle = getDLInstance();
+	device::AudioOutputPortConfig::getInstance().load(pDLHandle);
+	device::VideoOutputPortConfig::getInstance().load(pDLHandle);
+	device::VideoDeviceConfig::getInstance().load(pDLHandle);


The Manager::load() method calls load for AudioOutputPortConfig, VideoOutputPortConfig, and VideoDeviceConfig, but does not call FrontPanelConfig::getInstance().load(pDLHandle). This is inconsistent with Manager::Initialize() which calls load on all four config classes including FrontPanelConfig. This inconsistency could lead to FrontPanelConfig not being properly loaded when Manager::load() is called.

Suggested change

device::VideoDeviceConfig::getInstance().load(pDLHandle);

device::VideoDeviceConfig::getInstance().load(pDLHandle);

device::FrontPanelConfig::getInstance().load(pDLHandle);

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

…logging format Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Reason for change: Address review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Reason for change: Addressed review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-11168, RDKEMW-4848: pass the proper handle to dsEnableHDCP (#182)

d3a2867

* RDKEMW-4848: pass the proper handle to dsEnableHDCP

suppal045 requested a review from a team as a code owner December 11, 2025 16:17

Copilot AI review requested due to automatic review settings December 11, 2025 16:17

Copilot started reviewing on behalf of suppal045 December 11, 2025 16:17 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings December 12, 2025 22:58

Copilot AI reviewed Dec 12, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings December 16, 2025 16:47

Copilot AI reviewed Dec 16, 2025

View reviewed changes

santoshcomcast added 21 commits January 6, 2026 10:48

RDKEMW-8587: consume the config variables using dlsym() in MW.

6abd424

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

fix build issue

59bbd5c

fix build issue

b08a24d

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

addressed review comments

9cc6b5f

fix build issue

ade5a61

fix build issue

6ac6e50

fix build issue

2dc944b

fix build issue

f6f3d48

fix build issue

441361b

fix coverity issue and removed unwanted code.

8d36de9

Fix build issue.

c676229

Addressed review comments.

968901d

Addressed review comments.

513b3c7

addressed review comments.

fb4785d

RDKEMW-8587: consume the config variables using dlsym() in MW.

35661b4

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

4c52eeb

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

fix build issue

e645685

RDKEMW-8587: consume the config variables using dlsym() in MW.

db4fa61

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

f5838f4

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

82e1bf4

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

2ee6669

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

santoshcomcast and others added 17 commits January 6, 2026 10:48

RDKEMW-8587: consume the config variables using dlsym() in MW.

f68259b

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

45e0530

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

43ad5ad

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

de32c1b

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

debug. disable dumpconfig and add logs

efe2f43

enable debugconfig

a84c6eb

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

move the debug prints within if condtion for all config dumpconfig

2b96a08

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

added few more logs, lock_guard in searchconfig

703701e

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

add delay while every load

0ba55bf

RDKEMW-8587: Fix dl symbol crash issue

b69cb63

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix dl symbol crash issue

0b96ee2

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix dl symbol crash issue

32d57fb

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix build error

7ae4eb6

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix FPD std::logical_error crash issue and enhanced the …

cca3783

…logging format Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fixed the coverity issues

01776ad

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

17564c6

Reason for change: Address review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

b8cdf99

Reason for change: Addressed review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

santoshcomcast force-pushed the feature/RDKEMW-8587-dlsym branch from ef2294f to b8cdf99 Compare January 6, 2026 05:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/rdkemw 8587 dlsym#186

Feature/rdkemw 8587 dlsym#186
suppal045 wants to merge 39 commits intotestfrom
feature/RDKEMW-8587-dlsym

suppal045 commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	INT_INFO("Read Old Configs\n");
	INT_INFO("Using OLD config loading\n");

	device::VideoDeviceConfig::getInstance().load(pDLHandle);
	device::VideoDeviceConfig::getInstance().load(pDLHandle);
	device::FrontPanelConfig::getInstance().load(pDLHandle);

Conversation

suppal045 commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants