RDKEMW-14445 : Add session end and protocol return to telemetry#182
RDKEMW-14445 : Add session end and protocol return to telemetry#182jthomp007c wants to merge 9 commits intodevelopfrom
Conversation
Reason for change: ctrlm currently does not know why xrsr might have ended a session. Also it does not know what protocol error may have occurred only that one did. Test Procedure: check telemetry for new fields, parse them, confirm that new data exists and is correct Priority: P0 Signed-off-by: Jason Thomson <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR extends voice-session telemetry so downstream analytics can see why a session ended (session end reason) and what protocol return code occurred, rather than only seeing that an error happened.
Changes:
- Extend
ctrlm.voice.session.statstelemetry payload to include session-end reason and protocol return code. - Propagate/standardize the “RCU session end reason” type across voice, RF4CE, BLE, IPC, and utils.
- Update legacy IARM voice events to use the renamed end-reason enum type.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/voice/telemetry/ctrlm_voice_telemetry_events.h | Updates session stats telemetry API and adds new stored fields. |
| src/voice/telemetry/ctrlm_voice_telemetry_events.cpp | Emits the new telemetry fields and updates session-end stats handling. |
| src/voice/ipc/ctrlm_voice_ipc_iarm_legacy.cpp | Casts legacy IARM “reason” fields to the updated end-reason enum type. |
| src/voice/ctrlm_voice_obj.h | Switches queue messages/session structures and APIs to the renamed end-reason type. |
| src/voice/ctrlm_voice_obj.cpp | Propagates renamed end-reason usage and wires session-end stats into telemetry. |
| src/rf4ce/ctrlm_rf4ce_network.cpp | Updates RF4CE stop handling to use renamed end-reason constants. |
| src/rf4ce/ctrlm_rf4ce_indication.cpp | Updates default/derived stop reasons to the renamed end-reason constants/types. |
| src/ctrlm_utils.h | Renames the end-reason-to-string helper declaration to match the new enum type. |
| src/ctrlm_utils.cpp | Renames/updates the end-reason-to-string helper implementation and cases. |
| src/ble/ctrlm_ble_network.h | Updates BLE voice-session end API to accept the renamed end-reason type. |
| src/ble/ctrlm_ble_network.cpp | Updates BLE voice-session end calls to pass renamed end-reason constants. |
| include/ctrlm_ipc_voice.h | Renames the public end-reason enum/type and updates IARM event struct fields accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dwolaver
left a comment
dwolaver
left a comment
There was a problem hiding this comment.
Just a couple of comments...
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: ctrlm currently does log why xrsr might have ended a session. Also it does not log what protocol error may have occurred. only that one did.
Test Procedure: check telemetry for new fields, parse them, confirm that new data exists and is correct
Priority: P0