RDKEMW-13340: correct telemetry when server did not return a string#180
Closed
jthomp007c wants to merge 3 commits intodevelopfrom
Closed
RDKEMW-13340: correct telemetry when server did not return a string#180jthomp007c wants to merge 3 commits intodevelopfrom
jthomp007c wants to merge 3 commits intodevelopfrom
Conversation
Reason for change: If a voice session fails in some way in which the server has not returned a status string, we will provide one Test Procedure: Ideally cause every error scenario to confirm all error strings Priority: P1 Risks: Low, just logging Signed-off-by: Jason Thomson <jason_thomson@comcast.com>
There was a problem hiding this comment.
Pull request overview
Improves voice session end telemetry by ensuring a non-empty server status string is recorded when the server doesn’t provide one.
Changes:
- Adds a fallback mapping from session end reason to a status string when
server_messageis empty. - Preserves the original server-provided message when present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egalla204
reviewed
Feb 17, 2026
Contributor
egalla204
left a comment
egalla204
left a comment
There was a problem hiding this comment.
approved for QA verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: If a voice session fails in some way in which the server has not returned a status string, we will provide one
Test Procedure: Ideally cause every error scenario to confirm all error strings
Priority: P1
Risks: Low, just logging