RDKB-62974 RDKB-62976: Native build for Coverity - Use Git Submodule #85
Conversation
manedurphy
commented
Feb 5, 2026
manedurphy
commented
- Please refer to the changes discussed in rdkcentral/common-library/#82 where the iterations of these changes were discussed
- Fixes GitHub Action path to build script - Compiles with the preprocessor flags shown in log.do_compile step - README.md updated to pointed to centralized documentation in build_tools_workflows
There was a problem hiding this comment.
Pull request overview
This PR migrates the native build system for Coverity from using a cloned repository approach to a Git submodule approach, centralizing build tools in the rdkcentral/build_tools_workflows repository.
Changes:
- Replaced wrapper scripts that cloned
build_tools_workflowswith direct usage via Git submodule - Reorganized and documented compiler flags in
configure_options.conffor better maintainability - Updated dependency configuration to use standardized build types and reordered dependencies
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cov_docker_script/run_setup_dependencies.sh | Removed wrapper script as build tools are now accessed via submodule |
| cov_docker_script/run_native_build.sh | Removed wrapper script as build tools are now accessed via submodule |
| cov_docker_script/run_external_build.sh | Removed wrapper script as build tools are now accessed via submodule |
| cov_docker_script/configure_options.conf | Reorganized compiler flags with categorization and added missing include paths |
| cov_docker_script/component_config.json | Simplified dependency configuration and reordered dependencies |
| cov_docker_script/README.md | Replaced detailed documentation with reference to centralized docs in build_tools_workflows |
| build_tools_workflows | Added as Git submodule pointing to develop branch |
| .gitmodules | Added submodule configuration for build_tools_workflows |
| .github/workflows/native-build.yml | Updated to use submodule-based build scripts instead of wrapper scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -D_2_5G_ETHERNET_SUPPORT_ | ||
| -D_BRIDGE_UTILS_BIN_ | ||
|
|
||
| # Cable Modem & DOCSIS |
There was a problem hiding this comment.
Section comment incorrectly categorizes MACsec support. MACsec (line 109) is a Layer 2 security protocol for Ethernet and is not specific to Cable Modem or DOCSIS.
| -DFEATURE_RDKB_INTER_DEVICE_MANAGER | ||
| -D_MACSEC_SUPPORT_ | ||
|
|
||
| # MAP-T / NAT46 (IPv4/IPv6 Translation) |
There was a problem hiding this comment.
The comment describing MAP-T includes a parenthetical clarification '(IPv4/IPv6 Translation)'. While technically correct, MAP-T specifically refers to 'Mapping of Address and Port with Translation' which is a more precise description than the generic 'IPv4/IPv6 Translation' term.
| # MAP-T / NAT46 (IPv4/IPv6 Translation) | |
| # MAP-T (Mapping of Address and Port with Translation) / NAT46 |
| "meson setup build --prefix=$HOME/usr", | ||
| "meson compile -C build" | ||
| ] | ||
| "type": "meson" |
There was a problem hiding this comment.
The build configuration for trower-base64 was changed from explicit meson commands to simplified 'type: meson'. Ensure that the default meson build behavior (which would typically use 'meson setup builddir --prefix=$HOME/usr' and 'meson compile -C builddir') produces the same result as the previous explicit commands, particularly regarding the prefix path.
| "type": "meson" | |
| "type": "custom", | |
| "commands": [ | |
| "meson setup builddir --prefix=$HOME/usr", | |
| "meson compile -C builddir" | |
| ] |
2 participants
