RDKB-60656 : Available memory check for firmware downloads #23
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
|
Check failure on line 3 in source/CMAgentSsp/ssp_main.c
|
||
| * | ||
| * Copyright 2015 RDK Management | ||
| * | ||
|
|
@@ -51,6 +51,7 @@ | |
| //#include <docsis_ext_interface.h> | ||
| #include "safec_lib_common.h" | ||
| #include "syscfg/syscfg.h" | ||
| #include "telemetry_busmessage_sender.h" | ||
| #include <sys/stat.h> | ||
|
|
||
| #define DEBUG_INI_NAME "/etc/debug.ini" | ||
|
|
@@ -960,6 +961,7 @@ | |
| CcspTraceInfo(("pthread create docsis registration\n")); | ||
| pthread_create(&docsisclbk_tid, NULL, GWP_docsisregistration_threadfunc, NULL); | ||
| #endif | ||
| t2_init("CcspCMAgent"); | ||
|
There was a problem hiding this comment. The addition of t2_init call appears unrelated to the stated PR objective of adding available memory check for firmware downloads. If telemetry is needed for reporting memory check failures or firmware download metrics, this should be mentioned in the PR description. Otherwise, this change should be in a separate PR to maintain clear separation of concerns. |
||
| cmd_dispatch('e'); | ||
| // printf("Calling Docsis\n"); | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,7 +29,7 @@ libCcspCMAgent_integration_src_shared_la_CPPFLAGS = \ | |||||
| -I$(top_srcdir)/source/Custom | ||||||
|
|
||||||
| libCcspCMAgent_integration_src_shared_la_SOURCES = cosa_x_cisco_com_cablemodem_apis.c cosa_device_info_apis.c cosa_x_rdkcentral_com_cablemodem_apis.c | ||||||
| libCcspCMAgent_integration_src_shared_la_LDFLAGS = -lccsp_common -lcm_mgnt -lsysevent -lsecure_wrapper -lfw_download_chk | ||||||
|
There was a problem hiding this comment. The library "-lfw_download_chk" is added as a dependency but there's no verification that this library exists or is available in the build environment. Consider adding appropriate configuration checks (e.g., PKG_CHECK_MODULES or AC_CHECK_LIB in configure.ac) to ensure the library is available before attempting to link against it.
Suggested change
|
||||||
| if CORE_NET_LIB_FEATURE_SUPPORT | ||||||
| libCcspCMAgent_integration_src_shared_la_LDFLAGS += -lnet | ||||||
| endif | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
|
Check failure on line 3 in source/TR-181/integration_src.shared/cosa_device_info_apis.c
|
||
| * | ||
| * Copyright 2015 RDK Management | ||
| * | ||
|
|
@@ -77,6 +77,7 @@ | |
| #include "safec_lib_common.h" | ||
| #include <syscfg/syscfg.h> | ||
| #include "secure_wrapper.h" | ||
| #include "fw_download_check.h" | ||
|
|
||
| #define CM_HTTPURL_LEN 512 | ||
| #define VALID_fW_LEN 128 | ||
|
|
@@ -379,7 +380,6 @@ | |
| } | ||
| #endif | ||
|
|
||
| ANSC_STATUS CosaDmlDIDownloadNow(ANSC_HANDLE hContext) | ||
| { | ||
| PCOSA_DATAMODEL_DEVICEINFO pMyObject = (PCOSA_DATAMODEL_DEVICEINFO)hContext; | ||
|
|
@@ -491,6 +491,12 @@ | |
| } | ||
|
|
||
| } */ | ||
|
|
||
| if(can_proceed_fw_download() == FW_DWNLD_MEMCHK_NOT_ENOUGH_MEM){ | ||
| CcspTraceError(("CosaDmlDIDownloadNow : Not enough memory to proceed firmware download\n")); | ||
|
There was a problem hiding this comment. The error message lacks specific information about how much memory is available versus how much is required. Consider enhancing the error message to include actual memory values, which would be more helpful for debugging and troubleshooting in production environments. |
||
| return ANSC_STATUS_FAILURE; | ||
| } | ||
|
|
||
| pthread_t FWDL_Thread; | ||
| res = pthread_create(&FWDL_Thread, NULL, FWDL_ThreadFunc, "FWDL_ThreadFunc"); | ||
| if(res != 0) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of telemetry_busmessage_sender.h include and the corresponding t2_init call on line 964 appear unrelated to the stated PR objective of adding available memory check for firmware downloads. If telemetry is needed for reporting memory check failures or firmware download metrics, this should be mentioned in the PR description. Otherwise, this change should be in a separate PR to maintain clear separation of concerns.