RDKB-62709 RDKB-62780: Update Bootfile param to 255 char in CM Agent#20
Open
hirrangandhid wants to merge 6 commits intodevelopfrom
Open
RDKB-62709 RDKB-62780: Update Bootfile param to 255 char in CM Agent#20hirrangandhid wants to merge 6 commits intodevelopfrom
hirrangandhid wants to merge 6 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Cable Modem Agent’s TR-181 data model to allow longer DHCP bootfile names (IPv4 and IPv6), aligning with the stated CableLabs-driven requirement to support up to 255 characters.
Changes:
- Increased
BootFileNameandIPv6BootFileNamebuffer sizes in CM DHCP info structs from 64 to 256. - Updated TR-181 XML parameter type constraints for
BootFileNameandIPv6BootFileNamefromstring(64)tostring(256).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| source/TR-181/include/cosa_x_cisco_com_cablemodem_apis.h | Expands DHCP info struct fields to hold longer bootfile names. |
| config-arm/TR181-CM.XML | Updates TR-181 parameter length constraints for bootfile name fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-62709 RDKB-62780: Update Bootfile param to 255 char in CM Agent
Reason for change: To meet with Cablelabs standard, change Bootfile param to 255 characters.
Test Procedure: Set the bootfile name to greater than 64 characters and confirm that no errors are reported. Build should get success and ensure no regression.
Risks: medium
Priority: P1