RDKB-62985 RDKB-62986: Native build for Coverity #39
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,36 @@ | ||||||||||
| name: Build Advanced Security Component in Native Environment | ||||||||||
|
|
||||||||||
| on: | ||||||||||
| push: | ||||||||||
| branches: [ main, 'sprint/**', 'release/**', develop ] | ||||||||||
| pull_request: | ||||||||||
| branches: [ main, 'sprint/**', 'release/**', topic/RDK*, develop ] | ||||||||||
|
|
||||||||||
| jobs: | ||||||||||
| build-advanced-security-on-pr: | ||||||||||
| name: Build advanced-security component in github rdkcentral | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| container: | ||||||||||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout code | ||||||||||
| uses: actions/checkout@v3 | ||||||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment.
Suggested change
|
||||||||||
|
|
||||||||||
| - name: native build | ||||||||||
| run: | | ||||||||||
| # Trust the workspace | ||||||||||
| git config --global --add safe.directory '*' | ||||||||||
|
There was a problem hiding this comment. Setting
Suggested change
|
||||||||||
|
|
||||||||||
| # Pull the latest changes for the native build system | ||||||||||
| git submodule update --init --recursive --remote | ||||||||||
|
|
||||||||||
| # Build and install dependencies | ||||||||||
| chmod +x build_tools_workflows/cov_docker_script/setup_dependencies.sh | ||||||||||
| ./build_tools_workflows/cov_docker_script/setup_dependencies.sh ./cov_docker_script/component_config.json | ||||||||||
|
|
||||||||||
| # Build component | ||||||||||
| chmod +x build_tools_workflows/cov_docker_script/build_native.sh | ||||||||||
| ./build_tools_workflows/cov_docker_script/build_native.sh ./cov_docker_script/component_config.json "$(pwd)" | ||||||||||
| env: | ||||||||||
| GITHUB_TOKEN: ${{ secrets.RDKCM_RDKE }} | ||||||||||
|
There was a problem hiding this comment. Overriding
Suggested change
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| [submodule "build_tools_workflows"] | ||
| path = build_tools_workflows | ||
| url = https://github.com/rdkcentral/build_tools_workflows | ||
| branch = develop |
Submodule build_tools_workflows
added at
b7c962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # 🔧 Coverity Native Build System for RDK-B Components | ||
|
|
||
| The documentation and source for the RDK-B native build system has been centralized in [rdkcentral/build_tools_workflows](https://github.com/rdkcentral/build_tools_workflows/blob/develop/cov_docker_script/README.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,99 @@ | ||||||
| { | ||||||
| "_comment": "Component Build Configuration for Coverity/Native Builds", | ||||||
| "_version": "2.0", | ||||||
| "_description": "Defines dependencies and build settings for the native component", | ||||||
|
|
||||||
| "dependencies": { | ||||||
|
There was a problem hiding this comment. JSON indentation is inconsistent here (this key doesn’t align with surrounding fields). Reformatting the file with a consistent JSON formatter will make future edits and reviews less error-prone.
Suggested change
|
||||||
| "_comment": "External repositories needed by this component", | ||||||
| "repos": [ | ||||||
| { | ||||||
| "name": "common-library", | ||||||
| "repo": "https://github.com/rdkcentral/common-library.git", | ||||||
| "branch": "develop", | ||||||
| "header_paths": [ | ||||||
| { "source": "source/cosa/include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/cosa/include/linux", "destination": "$HOME/usr/include/rdkb/linux" }, | ||||||
| { "source": "source/cosa/include/linux", "destination": "$HOME/usr/include/rdkb/" }, | ||||||
|
There was a problem hiding this comment. The same source directory is copied to two different destinations, including the include root (
Suggested change
|
||||||
| { "source": "source/ccsp/custom", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/ccsp/include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/debug_api/include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/util_api/http/include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/ccsp/components/include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/util_api/ansc/include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/dm_pack", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/cosa/package/slap/include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "source/ccsp/components/common/MessageBusHelper/include", "destination": "$HOME/usr/include/rdkb" } | ||||||
| ], | ||||||
| "build": { | ||||||
| "type": "script", | ||||||
| "script": "build_tools_workflows/cov_docker_script/common_external_build.sh" | ||||||
| } | ||||||
| }, | ||||||
| { | ||||||
| "name": "rdkb-halif-platform", | ||||||
| "repo": "https://github.com/rdkcentral/rdkb-halif-platform.git", | ||||||
| "branch": "main", | ||||||
| "header_paths": [ | ||||||
| { "source": "include", "destination": "$HOME/usr/include/rdkb/ccsp" } | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
| "name": "rdkb-halif-cm", | ||||||
| "repo": "https://github.com/rdkcentral/rdkb-halif-cm.git", | ||||||
| "branch": "main", | ||||||
| "header_paths": [ | ||||||
| { "source": "include", "destination": "$HOME/usr/include/rdkb/ccsp" } | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
| "name": "rbus", | ||||||
| "repo": "https://github.com/rdkcentral/rbus.git", | ||||||
| "branch": "v2.7.0", | ||||||
| "header_paths": [ | ||||||
| { "source": "include", "destination": "$HOME/usr/include/rdkb" }, | ||||||
| { "source": "src/rbus", "destination": "$HOME/usr/include/rdkb/rbus" } | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
| "name": "WebconfigFramework", | ||||||
| "repo": "https://github.com/rdkcentral/WebconfigFramework.git", | ||||||
| "branch": "develop", | ||||||
| "header_paths": [ | ||||||
| { "source": "include", "destination": "$HOME/usr/include/rdkb" } | ||||||
| ], | ||||||
| "build": { | ||||||
| "type": "autotools", | ||||||
| "configure_flags": "CPPFLAGS=\"-I$HOME/usr/include/rdkb -I$HOME/usr/include/rdkb/rbus -I$HOME/usr/local/include -I$HOME/usr/include/rdkb/rtmessage\" LDFLAGS=\"-L$HOME/usr/local/lib -L$HOME/usr/lib\" LIBS=\"-lrbus -lrtMessage\"" | ||||||
| } | ||||||
| }, | ||||||
| { | ||||||
| "name": "Utopia", | ||||||
| "repo": "https://github.com/rdkcentral/utopia.git", | ||||||
| "branch": "develop", | ||||||
| "header_paths": [ | ||||||
| { "source": "source/include/syscfg", "destination": "$HOME/usr/include/rdkb/syscfg" } | ||||||
| ], | ||||||
| "build": { | ||||||
| "type": "script", | ||||||
| "script": "build_tools_workflows/cov_docker_script/common_external_build.sh" | ||||||
| } | ||||||
| } | ||||||
| ] | ||||||
| }, | ||||||
| "native_component": { | ||||||
| "_comment": "Configuration for the main component being built", | ||||||
| "name": "advanced-security", | ||||||
| "include_path": "$HOME/usr/include/rdkb/", | ||||||
| "lib_output_path": "$HOME/usr/local/lib/", | ||||||
| "pre_build_commands": [ | ||||||
| { | ||||||
| "description": "Generate dm_pack_datamodel.c from XML", | ||||||
| "command": "python3 $HOME/usr/include/rdkb/dm_pack_code_gen.py config/TR181-AdvSecurity.xml source/AdvSecuritySsp/dm_pack_datamodel.c" | ||||||
| } | ||||||
| ], | ||||||
| "build": { | ||||||
| "type": "autotools", | ||||||
| "configure_options_file": "cov_docker_script/configure_options.conf" | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
Contributor
There was a problem hiding this comment. Is this configuration taken from do_compile log ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,153 @@ | ||||||||||
| # Advanced Security Configure Options | ||||||||||
| # This file contains autotools configure options for the advanced-security component | ||||||||||
|
|
||||||||||
| # ============================================================================ | ||||||||||
| # CPPFLAGS - Preprocessor flags (includes and defines) | ||||||||||
| # ============================================================================ | ||||||||||
| [CPPFLAGS] | ||||||||||
|
|
||||||||||
| # Autotools configuration | ||||||||||
| -DHAVE_CONFIG_H | ||||||||||
|
|
||||||||||
| # Include paths | ||||||||||
| -I$HOME/usr/include/rdkb/ | ||||||||||
| -I/usr/include/dbus-1.0 | ||||||||||
| -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include | ||||||||||
| -I/usr/include/cjson | ||||||||||
|
|
||||||||||
| # ANSC framework defines | ||||||||||
| -D_ANSC_LINUX | ||||||||||
| -D_ANSC_USER | ||||||||||
| -D_ANSC_LITTLE_ENDIAN_ | ||||||||||
| -D_ANSC_USE_OPENSSL_ | ||||||||||
| -D_ANSC_AES_USED_ | ||||||||||
| -D_NO_ANSC_ZLIB_ | ||||||||||
| -U_ANSC_IPV6_COMPATIBLE_ | ||||||||||
|
|
||||||||||
| # Core system / HAL | ||||||||||
| -D_COSA_HAL_ | ||||||||||
| -U_COSA_SIM_ | ||||||||||
| -D_COSA_INTEL_USG_ARM_ | ||||||||||
| -D_COSA_BCM_ARM_ | ||||||||||
| -D_COSA_FOR_COMCAST_ | ||||||||||
|
|
||||||||||
| # CCSP/Component defines | ||||||||||
| -D_CCSP_CWMP_TCP_CONNREQ_HANDLER | ||||||||||
| -D_DSLH_STUN_ | ||||||||||
| -D_NO_PKI_KB5_SUPPORT | ||||||||||
| -D_BBHM_SSE_FILE_IO | ||||||||||
| -DCCSP_SUPPORT_ENABLED | ||||||||||
|
|
||||||||||
| # Security / debugging | ||||||||||
| -DENABLE_SA_KEY | ||||||||||
| -D_NO_EXECINFO_H_ | ||||||||||
| -D_DEBUG | ||||||||||
| -DINCLUDE_BREAKPAD | ||||||||||
|
|
||||||||||
| # System features | ||||||||||
| -DFEATURE_SUPPORT_RDKLOG | ||||||||||
| -DFEATURE_SUPPORT_SYSLOG | ||||||||||
| -DBUILD_WEB | ||||||||||
| -DUSE_NOTIFY_COMPONENT | ||||||||||
| -DNTPD_ENABLE | ||||||||||
| -DUTC_ENABLE | ||||||||||
| -DUTC_ENABLE_ATOM | ||||||||||
| -DXDNS_ENABLE | ||||||||||
|
|
||||||||||
| # Product/Platform defines | ||||||||||
| -D_XB6_PRODUCT_REQ_ | ||||||||||
| -D_XB7_PRODUCT_REQ_ | ||||||||||
| -D_XB8_PRODUCT_REQ_ | ||||||||||
| -DCONFIG_VENDOR_NAME | ||||||||||
|
|
||||||||||
| # MoCA-related | ||||||||||
| -DCONFIG_SYSTEM_MOCA | ||||||||||
| -DMOCA_HOME_ISOLATION | ||||||||||
| -DMOCA_DIAGONISTIC | ||||||||||
|
There was a problem hiding this comment. Possible typo in macro name:
Suggested change
|
||||||||||
|
|
||||||||||
| # Network features | ||||||||||
| -DENABLE_ETH_WAN | ||||||||||
| -DEROUTER_DHCP_OPTION_MTA | ||||||||||
| -DETH_4_PORTS | ||||||||||
| -D_2_5G_ETHERNET_SUPPORT_ | ||||||||||
| -D_MACSEC_SUPPORT_ | ||||||||||
| -D_BRIDGE_UTILS_BIN_ | ||||||||||
| -DAUTOWAN_ENABLE | ||||||||||
| -DENABLE_WANMODECHANGE_NOREBOOT | ||||||||||
| -DFEATURE_RDKB_WAN_MANAGER | ||||||||||
| -DFEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE | ||||||||||
| -DWAN_MANAGER_UNIFICATION_ENABLED | ||||||||||
| -DWAN_FAILOVER_SUPPORTED | ||||||||||
| -DGATEWAY_FAILOVER_SUPPORTED | ||||||||||
| -DFEATURE_RDKB_DHCP_MANAGER | ||||||||||
|
|
||||||||||
| # WiFi features | ||||||||||
| -D_ENABLE_BAND_STEERING_ | ||||||||||
| -D_BEACONRATE_SUPPORT | ||||||||||
| -D_TRI_BAND_WIFI_ | ||||||||||
| -D_WIFI_AX_SUPPORT_ | ||||||||||
| -D_WIFI_CONSOLIDATED_STANDARDS_ | ||||||||||
| -DWIFI_HAL_VERSION_3 | ||||||||||
| -DFEATURE_SUPPORT_MESH | ||||||||||
| -DFEATURE_SUPPORT_WEBCONFIG | ||||||||||
| -DFEATURE_SUPPORT_INTERWORKING | ||||||||||
| -DFEATURE_SUPPORT_PASSPOINT | ||||||||||
| -DWIFI_STATS_DISABLE_SPEEDTEST_RUNNING | ||||||||||
| -DFEATURE_SUPPORT_RADIUSGREYLIST | ||||||||||
| -DFEATURE_SUPPORT_ACL_SELFHEAL | ||||||||||
| -DFEATURE_CSI | ||||||||||
| -DFEATURE_SUPPORT_ONBOARD_LOGGING | ||||||||||
| -DFEATURE_OFF_CHANNEL_SCAN_5G | ||||||||||
| -DRDK_ONEWIFI | ||||||||||
| -DWIFI_MANAGE_SUPPORTED | ||||||||||
|
|
||||||||||
| # Advanced features | ||||||||||
| -D_PSM_TRANS_RDK_TRIGG_ | ||||||||||
| -D_CM_HIGHSPLIT_SUPPORTED_ | ||||||||||
| -DFEATURE_RDKB_INTER_DEVICE_MANAGER | ||||||||||
| -DFEATURE_SUPPORT_MAPT_NAT46 | ||||||||||
| -DMAPT_UNIFICATION_ENABLED | ||||||||||
| -DSPEED_BOOST_SUPPORTED | ||||||||||
| -DAMENITIES_NETWORK_ENABLED | ||||||||||
|
|
||||||||||
| # Build system / misc | ||||||||||
| -DRBUS_BUILD_FLAG_ENABLE | ||||||||||
|
|
||||||||||
| # Test/Development | ||||||||||
| -DCOLUMBO_HWTEST | ||||||||||
|
|
||||||||||
| # DML specific defines | ||||||||||
| -DDML_SUPPORT | ||||||||||
| -DNON_PRIVILEGED | ||||||||||
|
|
||||||||||
| # ============================================================================ | ||||||||||
| # CFLAGS - Compiler flags | ||||||||||
| # ============================================================================ | ||||||||||
| [CFLAGS] | ||||||||||
|
|
||||||||||
| # Optimization | ||||||||||
| -Os | ||||||||||
| -pipe | ||||||||||
| -g | ||||||||||
| -feliminate-unused-debug-types | ||||||||||
|
|
||||||||||
| # Warnings | ||||||||||
| -Wall | ||||||||||
| -Wextra | ||||||||||
|
|
||||||||||
| # Code generation | ||||||||||
| -fno-exceptions | ||||||||||
| -ffunction-sections | ||||||||||
| -fdata-sections | ||||||||||
| -fomit-frame-pointer | ||||||||||
| -fno-strict-aliasing | ||||||||||
| -fcommon | ||||||||||
|
|
||||||||||
|
|
||||||||||
| # ============================================================================ | ||||||||||
| # LDFLAGS - Linker flags | ||||||||||
| # ============================================================================ | ||||||||||
| [LDFLAGS] | ||||||||||
| -L$HOME/usr/local/lib/ | ||||||||||
| -Wl,--allow-shlib-undefined | ||||||||||
| -Wl,--unresolved-symbols=ignore-all | ||||||||||
|
Comment on lines
+151
to
+153
There was a problem hiding this comment. These linker flags suppress unresolved-symbol failures, which can hide real link problems and reduce the value of CI (and potentially Coverity) by allowing incomplete binaries. Prefer failing the build on unresolved symbols; if suppression is required for specific optional libs, scope it narrowly (e.g., only for affected targets) rather than globally in
Suggested change
|
||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the
latesttag makes CI non-reproducible and can break builds when the image changes. Pin the container image to a specific version tag or immutable digest (e.g.,@sha256:...) so Coverity/native builds are stable over time.