RDKEMW-12989 : Removal of WPEFramework/ Thunder process check from Plugin Activator #8
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the upfront process check that verified whether WPEFramework or Thunder was running before attempting plugin activation/deactivation operations. The change simplifies the code by relying entirely on the existing COM-RPC connection retry mechanism to handle cases where the Thunder service is unavailable.
Changes:
- Removed
getPID()andisRunning()helper functions that checked for running processes - Eliminated the pre-flight validation that exited early if neither WPEFramework nor Thunder was detected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ivator Reason for change: Removed the Thunde/WPEFramework running check before activate /deactivate request Test Procedure: please refer the ticket comments Risks: Medium Signed-off-by: Thamim Razith Abbas Ali <tabbas651@cable.comcast.com>
karuna2git
approved these changes
Jan 27, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDKEMW-12989 : Removal of WPEFramework/ Thunder process check from Plugin Activator
Reason for change: Removed the Thunde/WPEFramework running check before activate /deactivate request
Test Procedure: please refer the ticket comments
Risks: Medium
Signed-off-by: Thamim Razith Abbas Ali tabbas651@cable.comcast.com