RDK-53592 L1/L2 run_ut.sh script for OCDM client repository#292
RDK-53592 L1/L2 run_ut.sh script for OCDM client repository#292NRofina wants to merge 2 commits intordkcentral:masterfrom
Conversation
Reason for change : run.sh script added to install dependencies and run tests Test procedure: Run run.sh and check tests are executed and reports generated Risks: Low Signed-off-by: nkader321 <NoorjahanRofina_KaderMohideen@comcast.com>
|
nkader321 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ develop, main ] |
There was a problem hiding this comment.
We don't have either develop or main branches in this repo, and usually we run all workflows on both pull requests and pushes to master.
But in this case, it looks like the intention is to test code for R5_1, since all other repositories are checked out for these branches, correct?
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Perhaps it would be safer to specific the Ubuntu version here, e.g. ubuntu-24.04
There was a bug once which could lead to latest being interpreted differently across various workflows, plus it is easier to maintain without the Ubuntu version changing on its own, which could make some packages no longer available
Reason for change : run.sh script added to install dependencies and run tests
Test procedure: Run run.sh and check tests are executed and reports generated
Risks: Low
Signed-off-by: nkader321 NoorjahanRofina_KaderMohideen@comcast.com