wifi_8021x: fix null pointer dereference in process_eap_data #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process_eap_data function was dereferencing data->data before checking if the pointers were NULL, which could lead to segmentation faults. This commit moves the null checks to the beginning of the function and returns early if null pointers are detected, preventing the dereference from occurring. Changes: - Add null check for data and data->data at function start - Return early with error logging if NULL - Remove redundant null checks before free() calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
process_eap_datafunction insource/core/wifi_8021x.cto move null checks for data and data->data to the beginning of the function and return early to avoid segfaults.Changes Made
dataanddata->dataat function startfree()callsTesting